Carousel: Closing Carousel view goes back to Previous page

[jeherve]

Steps to reproduce the issue

1. On a new site, install the "Travern" theme from the WordPress.org theme directory (Themes > Add New).
2. Create a gallery on a site where Jetpack and the Carousel module are active.
3. Load your site's home page.
4. Navigate to the post / page where you've added the gallery.
5. Click on an image to load the Carousel view.
6. Click on the "x" icon to close the carousel view.
7. Instead of just closing the carousel view, the icon will act as if you had clicked on the browser's back button.

Reported here:
https://wordpress.org/support/topic/tiled-gallery-problems-with-nikkon-theme

[andykay]

I'm getting the same behaviour using a customised Bones theme - http://dev.robscottphotography.com/

Also if I increase the page load time by setting Photon compression to 100, clicking on an image quickly takes me to the attachment page rather than loading the carousel.

The rest of the behaviour is as above - opening the carousel before the images have loaded causes the close button to act as the browsers back button.

[jeherve]

This may be linked to #5168.

This is a bigger problem when accessing Carousel images directly:

1. Load a Carousel View in your browser right away: https://jeremy.hu/introducing-watson/#jp-carousel-1852
2. Click on the 'x' icon to leave the Carousel view.
3. The whole page disappears, as there is no previous page to go to.

[TopoR]

Yes, same issue :(

[ghost]

Same thing here...

[PatrizioRD]

Me as well, just stumbled upon the same issue.

[brezocordero]

Reported as well here #776598-zen

[designsimply]

I tested using the steps provided and added a step to adjust Chrome dev tools to simulate a slower connection. Please note browser details and/or any differences in the steps if you have tested and reproduced this bug!

My added step:

0. Select Chrome > Developer > Developer Tools > Network > Fast 3G.

My results: clicking the "x" to exit the gallery always returned me to the gallery page as expected.

Video: https://cloudup.com/cMFfyL3cTCl

Tested with Firefox 56.0.2 and Firefox 56.0.2 on Mac OS X 10.12.6.

[sandymcfadden]

Reported again in #1121771-zen
I've been able to replicate it consistently in Google Chrome 65 on OS X 10.13.4 on WordPress.com sites when not logged into WordPress.com. My personal site is an example https://sandy.mcfadden.blog/2017/11/04/beautiful-fall-morning/
I still think it has to do with the site not loading completely as it seems ads possibly are not finishing to load. Similar to the site in the user report.

[laurelfulford]

Another report here: #1135929-zen

Similar experience to the one above -- the site doesn't seem to load completely due to the ads, and the issue goes away when the ads are turned off.

[topher1kenobe]

I have another occurrence, but AdWords is not in play. The site appears to load fully, with no JS errors in the console. https://currentlyaway.com/2018/04/15/a-birthday-inspired-by-donastia/

[chaselivingston]

Also reported in 1240610-zen

[donalirl]

Another report in #446568-hc

[sirreal]

Another report: 1701275-zen (cc: @dericleeyy)

Also noticed when debugging #11152 and related ticket.

[sirreal]

There's a very simple way to reproduce this bug:

• Open a carousel
• Copy the URL from the browser, it will include a carousel fragment at the end like #jp-carousel-XXXX
• Open a private (incognito) brower window
• Paste and navigate to the carousel URL including the hash
• Close the carousel
• You will be sent to the "main" private window.

---

It seems that the conditions here need to be adjusted:

jetpack/modules/carousel/jetpack-carousel.js

Lines 392 to 398 in 48db8b5

	.bind('jp_carousel.afterClose', function(){
	if ( window.location.hash && history.back ) {
	history.back();
	}
	last_known_location_hash = '';
	gallery.opened = false;
	})

[stale]

This issue has been marked as stale. This happened because:

• It has been inactive in the past 6 months.
• It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

[khaoticdude]

Any update to this? I am still seeing this issue

[jeherve]

Also reported in #24021.