Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel: exits to site main page #24021

Closed
khaoticdude opened this issue Apr 20, 2022 · 10 comments
Closed

Carousel: exits to site main page #24021

khaoticdude opened this issue Apr 20, 2022 · 10 comments
Labels
[Closed] Duplicate Duplicate of an existing issue. [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Bug When a feature is broken and / or not performing as intended

Comments

@khaoticdude
Copy link

khaoticdude commented Apr 20, 2022

Impacted plugin

Jetpack

Steps to Reproduce

  1. Enable Jetpack Carousel
  2. Open image within a post to initiate the carousel
  3. Try exit the image by clicking the given exit indicator

A clear and concise description of what you expected to happen.

When you exit the carousel image, you should be sent back to the post (same as if you pressed "escape" in the carousel)

What actually happened

When trying to exit an image that is opened via the carousel, you are redirected to the site's main page. There seems to be an overlay issue or something.

Other information

No response

Operating System

Linux

OS Version

No response

Browser

Firefox

Browser Version(s)

No response

@khaoticdude khaoticdude added the [Type] Bug When a feature is broken and / or not performing as intended label Apr 20, 2022
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Apr 20, 2022
@jeherve jeherve added [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Apr 22, 2022
@jeherve
Copy link
Member

jeherve commented Apr 22, 2022

Similar issue: #6244

I cannot seem to reproduce on my end. Could you post a link to a page where you experience this problem?

Could you also try with a different theme, like one of the default WordPress themes, and let us know if this still happens?

Thank you!

@khaoticdude
Copy link
Author

khaoticdude commented Apr 22, 2022 via email

@khaoticdude
Copy link
Author

Looks like trying with a Wordpress theme works fine. This leads me to assume it may be some custom CSS I added.

@khaoticdude
Copy link
Author

Looks like trying with a Wordpress theme works fine. This leads me to assume it may be some custom CSS I added.

Removed all custom CSS and still get the issue. I guess the theme changed at some point.

@khaoticdude
Copy link
Author

Seems to be an issue with the Travern theme and jetpack

@jeherve
Copy link
Member

jeherve commented Apr 25, 2022

Thanks for the extra details. Is this the theme you're using?
https://themeforest.net/item/tavern-professional-restaurant-theme/10984149

@khaoticdude
Copy link
Author

No, this is the theme I am user https://flythemes.net/wordpress-themes/travel-wordpress-theme/

I reached out to the theme's support email and they requested I give them login credentials so they can check the backend on my server. I can't tell if it was a joke or not...

@jeherve
Copy link
Member

jeherve commented Apr 25, 2022

Thanks, I had missed the extra "r" in the theme's name :)

Since it's a premium theme I cannot download it to test on a test site of mine, but looking at the demo page, I see that the theme loads a number of js files on each page. Do you have a way to deactivate some of the features that rely on JavaScript in the theme settings? I see there are different sliders that rely on JavaScript for example. That may help us narrow things down a bit, and figure out what's causing this.

@khaoticdude
Copy link
Author

You should be able to install the theme via the WP theme panel. That's how I installed it.

@jeherve
Copy link
Member

jeherve commented Apr 26, 2022

Thank you! The theme is indeed available in the WordPress.org theme directory as well, and I was able to reproduce the issue with that theme active. 👍

I've updated the description in #6244 so it's now a lot easier to reproduce and investigate.

I'll close this issue now that we can continue the investigation in the original issue. Thanks for all the details!

@jeherve jeherve closed this as completed Apr 26, 2022
@jeherve jeherve added [Closed] Duplicate Duplicate of an existing issue. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Closed] Duplicate Duplicate of an existing issue. [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

2 participants