Feedback for demo1 internal build v1.0.0.7, based on v.1.0.0.6 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to binding all use cases to lifecycle at once on Activity startup
…geCapture use cases only when they're needed
…to release muxer and buffers
…surface-combination Handle CameraX use cases separately
6 tasks
…t stopped involuntarily
…equest while one is already progressing
…nother closing request
Added artificial wait to avoid a new capture request colliding previous request teardown
Setting TextView layertype as View.LAYER_TYPE_SOFTWARE
…h look when switching modes
…, as per the new designs
Implemented "Remove" area at the bottom
…of getting stuck halfway when swiping down
…idden behind the status bar
WIP - Status bar handling
mzorz
changed the title
|
==== produced build, should not receive further commits |
aforcier
changed the base branch from
demo1/1.0.0.5-feedback
to
issue/13-edit-screen
|
|
reviewed all component PRs and any loose commits that were made directly to this branch 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains [some/all] of the leftovers from #69, and will aggregate action items on feedback on 1.0.0.6
ToDo
Crashes
App crash on Android 5.1.1, 6.0, 7.0 Crash CameraX: No supported surface combination is found for camera device - Id : 0. #50fixed in Handle CameraX use cases separately #78tapping capture button repeatedly makes it crashAdded artificial wait to avoid a new capture request colliding previous request teardown #83Various
Emoji disappears when scaling out (zoom in)Setting TextView layertype as View.LAYER_TYPE_SOFTWARE #84Swiping down on the sheet, the stickers get stuck half way down and then you have to swipe again to fully dismiss the view.Done in 0830629 (Testing Version 1.0.0.5 (5) on a Pixel 2 #71 (comment))Top controls and status bar
Adjust top controls when status bar appears Move editing controls down so they're not hidden by the OS status bar #67Status bar handling #87