Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Version 1.0.0.5 (5) on a Pixel 2 #71

Closed
megsfulton opened this issue Aug 29, 2019 · 4 comments
Closed

Testing Version 1.0.0.5 (5) on a Pixel 2 #71

megsfulton opened this issue Aug 29, 2019 · 4 comments

Comments

@megsfulton
Copy link

Camera Capture

  • There's a white flash after taking a photo that seems new in this build?

Navigation Bar

  • Feels much more natural having it in there all the time 👍

Sticker sheet

  • Yay swipe up!
  • Swiping down on the sheet, the stickers get stuck half way down and then you have to swipe again to fully dismiss the view.
  • It's a little strange that the status bar appears with this view, can we hide it easily?

Text editing

  • Can the cursor color change to match the selected text color? It's pink by default, but if I select orange can the cursor change to orange?
@mzorz
Copy link
Contributor

mzorz commented Sep 1, 2019

There's a white flash after taking a photo that seems new in this build?

addressed in #80 in bd15985, going to be available on next build

@mzorz
Copy link
Contributor

mzorz commented Sep 1, 2019

Feels much more natural having it in there all the time 👍

🎉

Swiping down on the sheet, the stickers get stuck half way down and then you have to swipe again to fully dismiss the view.

haven't been able to reproduce unless I swipe slowly; if I quickly swipe down it gets dismissed, I guess that's how it works?. We can surely always implement our own behavior as per our desire, we can open a new issue for that if you agree.

It's a little strange that the status bar appears with this view, can we hide it easily?

Yeah, I noted this also in the original implementation here #48

Known issues:
when the emoji picker fragment is shown, the status bar appears. Spent a few minutes on this but couldn't figure it out, will open an issue with that.

Opened issue in #85

Can the cursor color change to match the selected text color? It's pink by default, but if I select orange can the cursor change to orange?

Nice catch! addressed in #80 , 91ba882

@mzorz
Copy link
Contributor

mzorz commented Sep 1, 2019

Having addressed / tracked the issues mentioned here elsewhere, going to close this one for now 👍

@mzorz mzorz closed this as completed Sep 1, 2019
@mzorz
Copy link
Contributor

mzorz commented Sep 2, 2019

Swiping down on the sheet, the stickers get stuck half way down and then you have to swipe again to fully dismiss the view.

Just added a tweak to make it more intuitive: now when you swipe down, if the list is already at its top it will fully swipe down and dismissed. If you swiped up showing the dialog, then swiped down further, a swipe down will first scroll down until the top element is reached (and then at this state it will fully swipe down and be dismissed if you swipe down again).
Done in 0830629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants