Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Gradle to 7.4 & AGP to 7.1.1 #719

Merged
merged 24 commits into from
Mar 23, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
7ca9f21
Build: Update gradle to 7.3.3
ParaskP7 Feb 28, 2022
21d4448
Build: Update agp to 7.0.4
ParaskP7 Feb 28, 2022
2ab10ac
Analysis: Resolve unused resources for strings on mp4 compose
ParaskP7 Feb 28, 2022
443a164
Analysis: Suppress unused resources for dimens on photo editor
ParaskP7 Feb 28, 2022
d4e3830
Analysis: Suppress unused resources for dimens on stories
ParaskP7 Feb 28, 2022
38bb1b5
Analysis: Suppress unused resources for colors on stories
ParaskP7 Feb 28, 2022
d397e19
Analysis: Suppress unused resources for strings on stories
ParaskP7 Feb 28, 2022
85c3af6
Analysis: Suppress unused resources for pop animation on stories
ParaskP7 Feb 28, 2022
7f31817
Analysis: Suppress recycler view for emoji picker fragment on stories
ParaskP7 Feb 28, 2022
3743bc8
Analysis: Suppress unused resources for all dimens on app
ParaskP7 Feb 28, 2022
598b0a6
Analysis: Suppress unused resources for all colors on app
ParaskP7 Feb 28, 2022
a056594
Analysis: Suppress unused resources for strings on app
ParaskP7 Feb 28, 2022
d110050
Analysis: Suppress unused resources for edit text style on app
ParaskP7 Feb 28, 2022
a9f02e9
Analysis: Suppress typos for font certs on app
ParaskP7 Feb 28, 2022
815361f
Analysis: Resolve unused resources for background drawable on app
ParaskP7 Feb 28, 2022
6d02eea
Analysis: Suppress unused resources for media par button drawable on app
ParaskP7 Feb 28, 2022
eb5c452
Analysis: Suppress content description for fab views on app
ParaskP7 Feb 28, 2022
ea8efc6
Analysis: Resolve content description for image views on app
ParaskP7 Feb 28, 2022
1c497e0
Analysis: Disable icon location errors on app
ParaskP7 Feb 28, 2022
01c062e
Refactor: Reformat pop animation on stories
ParaskP7 Feb 28, 2022
4975160
Build: Update gradle to 7.4
ParaskP7 Feb 28, 2022
a433946
Build: Update agp to 7.1.1
ParaskP7 Feb 28, 2022
9afca6a
CI: Update buildkite docker android build image to 1.2.0
ParaskP7 Mar 2, 2022
40bc82a
Merge branch 'trunk' of github.com:Automattic/stories-android into up…
ParaskP7 Mar 11, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/pipeline.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
common-params:
&publish-android-artifacts-docker-container
docker#v3.8.0:
image: "public.ecr.aws/automattic/android-build-image:v1.1.0"
image: "public.ecr.aws/automattic/android-build-image:v1.2.0"
propagate-environment: true
environment:
# DO NOT MANUALLY SET THESE VALUES!
Expand Down
1 change: 1 addition & 0 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ android {
lintOptions {
abortOnError false
lintConfig file('lint.xml')
disable("IconLocation")
}

useLibrary 'android.test.runner'
Expand Down
Binary file removed app/src/main/res/drawable/background.jpg
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
<?xml version="1.0" encoding="utf-8"?>
<vector xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:width="48dp"
android:height="48dp"
android:viewportHeight="48"
android:viewportWidth="48">
android:viewportWidth="48"
tools:ignore="UnusedResources">

<!-- @color/grey_lighten_20 -->
<path
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
<?xml version="1.0" encoding="utf-8"?>
<vector xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
android:width="48dp"
android:height="48dp"
android:viewportHeight="48"
android:viewportWidth="48">
android:viewportWidth="48"
tools:ignore="UnusedResources">

<!-- @color/almost_black -->
<path
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<selector xmlns:android="http://schemas.android.com/apk/res/android">
<selector xmlns:android="http://schemas.android.com/apk/res/android" xmlns:tools="http://schemas.android.com/tools" tools:ignore="UnusedResources">

<item android:drawable="@drawable/media_bar_button_image_multiple_disabled" android:state_enabled="false"/>
<item android:drawable="@drawable/media_bar_button_image_multiple_highlighted" android:state_focused="true"/>
Expand Down
3 changes: 2 additions & 1 deletion app/src/main/res/layout/activity_main.xml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
android:layout_gravity="bottom|end"
android:layout_margin="@dimen/fab_margin"
android:tint="@color/colorPrimary"
app:srcCompat="@drawable/ic_add_white_24dp"/>
app:srcCompat="@drawable/ic_add_white_24dp"
tools:ignore="ContentDescription" />

</androidx.coordinatorlayout.widget.CoordinatorLayout>
7 changes: 4 additions & 3 deletions app/src/main/res/layout/intro_template_view.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,12 @@
android:id="@+id/background_image"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_marginStart="@dimen/promo_background_image_margin_side"
android:layout_marginEnd="@dimen/promo_background_image_margin_side"
android:layout_marginBottom="@dimen/promo_background_image_margin_bottom"
android:layout_marginEnd="@dimen/promo_background_image_margin_side"
android:layout_marginStart="@dimen/promo_background_image_margin_side"
android:contentDescription="@null"
android:scaleType="centerCrop"
tools:src="@drawable/intro05"/>
tools:src="@drawable/intro05" />

<LinearLayout
android:layout_width="wrap_content"
Expand Down
7 changes: 4 additions & 3 deletions app/src/main/res/layout/intro_title_template_view.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,12 @@
android:id="@+id/background_image"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_marginStart="@dimen/promo_background_image_margin_side"
android:layout_marginEnd="@dimen/promo_background_image_margin_side"
android:layout_marginBottom="@dimen/promo_background_image_margin_bottom"
android:layout_marginEnd="@dimen/promo_background_image_margin_side"
android:layout_marginStart="@dimen/promo_background_image_margin_side"
android:contentDescription="@null"
android:scaleType="centerCrop"
tools:src="@drawable/intro01"/>
tools:src="@drawable/intro01" />

<LinearLayout
android:layout_width="wrap_content"
Expand Down
6 changes: 3 additions & 3 deletions app/src/main/res/layout/photo_picker_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="end|bottom"
android:layout_margin="@dimen/fab_margin"
android:backgroundTint="@color/pink_50"
android:tint="@color/white"
android:src="@drawable/ic_photo_camera_24px"
android:layout_margin="@dimen/fab_margin"
tools:ignore="InconsistentLayout"/>
android:tint="@color/white"
tools:ignore="ContentDescription,InconsistentLayout" />

<LinearLayout
android:layout_width="match_parent"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values/colors.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<resources>
<resources xmlns:tools="http://schemas.android.com/tools" tools:ignore="UnusedResources">
<color name="colorPrimary">@color/colorPrimary_wp</color>
<color name="colorPrimaryDark">@color/colorPrimaryDark_wp</color>
<color name="colorAccent">@color/colorAccent_wp</color>
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values/dimens.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<resources>
<resources xmlns:tools="http://schemas.android.com/tools" tools:ignore="UnusedResources">
<dimen name="fab_margin">16dp</dimen>
<dimen name="button_height">64dp</dimen>

Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values/font_certs.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
See the License for the specific language governing permissions and
limitations under the License.
-->
<resources>
<resources xmlns:tools="http://schemas.android.com/tools" tools:ignore="Typos">
<array name="com_google_android_gms_fonts_certs">
<item>@array/com_google_android_gms_fonts_certs_dev</item>
<item>@array/com_google_android_gms_fonts_certs_prod</item>
Expand Down
8 changes: 4 additions & 4 deletions app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<resources>
<resources xmlns:tools="http://schemas.android.com/tools">
<string name="app_name">loop</string>

<string name="main_placeholder">Still working on this! Tap the + to continue.</string>
Expand Down Expand Up @@ -32,12 +32,12 @@
<string name="photo_picker_soft_ask_allow">Allow</string>
<string name="photo_picker_soft_ask_label">%s needs permissions to access your photos</string>
<string name="photo_picker_device_desc">pick from device</string>
<string name="photo_picker_camera_desc">open camera</string>
<string name="photo_picker_wpmedia_desc">pick from WordPress media</string>
<string name="photo_picker_camera_desc" tools:ignore="UnusedResources">open camera</string>
<string name="photo_picker_wpmedia_desc" tools:ignore="UnusedResources">pick from WordPress media</string>
<string name="content_description_person_reading_device_notification">Person reading device with notifications</string>

<string name="dialog_general_announcement_title">General announcement</string>
<string name="dialog_general_announcement_message">This is an announcement you can make from the host app</string>
<string name="dialog_general_announcement_message" tools:ignore="UnusedResources">This is an announcement you can make from the host app</string>

<!-- Photo picker - Loop -->
<string name="photo_picker_add_photos_to_story">Choose the photos and videos you\'d like to add to your story</string>
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/res/values/styles.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<resources>
<resources xmlns:tools="http://schemas.android.com/tools">

<!-- Base application theme. -->
<style name="AppTheme" parent="Theme.AppCompat.Light.DarkActionBar">
Expand All @@ -25,7 +25,7 @@
<item name="colorAccent">?attr/colorPrimary</item>
</style>

<style name="EditText">
<style name="EditText" tools:ignore="UnusedResources">
<item name="android:singleLine">true</item>
<item name="colorControlNormal">#FFFFFF</item>
<item name="colorControlActivated">#FFFFFF</item>
Expand Down
Binary file modified gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.1.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.4-all.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
Loading