Upgrade Gradle to 7.4 & AGP to 7.1.1 #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error is about not treat position as fixed; Instead, to only use immediately and call holder.getAdapterPosition() to look it up later. RecyclerView will not call onBindViewHolder again when the position of the item changes in the data set unless the item itself is invalidated or the new position cannot be determined. For this reason, you should only use the position parameter while acquiring the related data item inside this method, and should not keep a copy of it. If you need the position of an item later on (e.g. in a click listener), use getAdapterPosition() which will have the updated adapter position. However, and in order not to cause any unintended issues on the current implementation of this screen, it is better to suppress this at the moment, come back to it with a fix and add accompanying adequate testing on top of the new solution afterwards.
The res/drawable folder is intended for density-independent graphics such as shapes defined in XML. For bitmaps, move it to drawable-mdpi and consider providing higher and lower resolution versions in drawable-ldpi, drawable-hdpi and drawable-xhdpi. If the icon really is density independent (for example a solid color) you can place it in drawable-nodpi. However, at this moment it is better to disable this warning as it only applies to the 5 x 'intro0X.png' images.
|
You can test the changes on this Pull Request by downloading the APK here. |
39 tasks
…date/gradle-to-7.3.3-agp-to-7.0.4
oguzkocer
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades
Gradle to 7.4&AGP to 7.1.1.It includes the following:
Gradleversion upgraded to7.3.3with the./gradlew wrapper --gradle-version=7.3.3 --distribution-type=allcommand.AGPversion upgrade to7.0.4(seesettings.gradlechange).Gradle 7.4&AGP 7.1.1.It suppresses the following Lint issues:
It disables the following Lint issues:
It resolves the following Lint issues:
It created the following GitHub issues:
Besides the above, you can reference the
Gradle 7.4 & AGP 7.1.1PRs of the below clients for testing/verification purposes:NOTE: This is a draft PR because all
Gradle & AGPupgrade PRs need to be merged together.Merge Instructions
Ready for reviewand assign https://github.com/orgs/wordpress-mobile/teams/owl-team to it.To Test