Merge stories creation save frame refactor #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… saveStory() method which loops through all Story's frames to decide how to save each one
…ed correctly before saving
… back after clearing and adding Frame's AddedViews to avoid capturing an uncomplete background
…ide loader, and using scaleType.CENTER_CROP on the PhotoEditorView as we were loading it with GLide's CenterCrop transform to achieve the same results
…toEditorViewForSnapshot and disabling layout animations to allow parent re-setting in onStoryFrameSelected
…ure/stories-creation-save-frame-refactor-part2
…ager, and added ViewUtils with removeViewFromParent method
…the same millisecond
…o feature/stories-creation-save-frame-refactor-part4
…y is finished saving
…o feature/stories-creation-save-frame-refactor-part4
…o feature/stories-creation-save-frame-refactor-part5-fixes
…e withContext wrapping async
…o feature/stories-creation-save-frame-refactor-part4
…o feature/stories-creation-save-frame-refactor-part5
…o feature/stories-creation-save-frame-refactor-part5-fixes
…-frame-refactor-part3 Save frame refactor part 3 (5)
…-frame-refactor-part4 Save frame refactor part 4 (6) - remove no longer used code
…-frame-refactor-part5 Save frame refactor part 5 (7) - save video frames
…-frame-refactor-part5-fixes Save frame refactor part 6 (8) - fix glitch on static background frames
|
You can test the changes on this Pull Request by downloading the APK here. |
|
|
aforcier
deleted the
feature/stories-creation-save-frame-refactor-base
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges the coroutine introduction refactor in
develop.All PRs have been reviewed and merge to the feature branch.
Contains #251, #252, #253, #254, #255, and #256.