Save frame refactor part 2 (4) #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…toEditorViewForSnapshot and disabling layout animations to allow parent re-setting in onStoryFrameSelected
…ure/stories-creation-save-frame-refactor-part2
|
You can test the changes on this Pull Request by downloading the APK here. |
aforcier
changed the base branch from
feature/stories-creation-save-frame-refactor
to
feature/stories-creation-save-frame-refactor-base
|
|
aforcier
deleted the
feature/stories-creation-save-frame-refactor-part2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #251
This PR creates an offscreen (ghost)
PhotoEditorViewonce for each time we want to save a Story, and is reused on each frame iteration to present Story frames offscreen for saving. This not only should be more performant than actually hitting the UI each time, but also would allow to process several frames concurrently (not part of this PR).