Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated rake file to remove bundle install --path depreciation notice #1139

Merged
merged 2 commits into from
Apr 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ XCODE_WORKSPACE = 'Simplenote.xcworkspace'
XCODE_SCHEME = 'Simplenote'
XCODE_CONFIGURATION = 'Debug'
PROJECT_DIR = __dir__
LOCAL_PATH = 'vendor/bundle'

task default: %w[test]

Expand All @@ -37,7 +38,8 @@ namespace :dependencies do

namespace :bundle do
task :check do
sh 'bundle check --path=${BUNDLE_PATH:-vendor/bundle} > /dev/null', verbose: false do |ok, _res|
sh "bundle config set --local path #{LOCAL_PATH} > /dev/null", verbose: false
sh 'bundle check > /dev/null', verbose: false do |ok, _res|
next if ok

# bundle check exits with a non zero code if install is needed
Expand All @@ -48,7 +50,7 @@ namespace :dependencies do

task :install do
fold('install.bundler') do
sh 'bundle install --jobs=3 --retry=3 --path=${BUNDLE_PATH:-vendor/bundle}'
sh 'bundle install --jobs=3 --retry=3'
end
end
CLOBBER << 'vendor/bundle'
Expand Down