Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated rake file to remove bundle install --path depreciation notice #1139

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

charliescheer
Copy link
Contributor

Fix

While working on SNiOS I noticed that bundle has depreciated using --path when invoking commands and suggests setting a config path value instead.

[DEPRECATED] The `--path` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set --local path 'vendor/bundle'`, and stop using this flag

In this PR I have updated the rake file to fix this depreciation

Test

  1. The bundle commands only run and show anything if it has to do work, so in terminal go to the SNiOS folder and type bundle exec gem uninstall nokogiri 1.15.4. Hit yes a couple of times to remove this gem
  2. type rake dependencies
  3. confirm that bundler runs without any depreciation notices

Review

(Required) Add instructions for reviewers. For example:

Only one developer is required to review these changes, but anyone can perform the review.

Release

These changes do not require release notes.

@charliescheer charliescheer added the tooling Related to anything that supports the building & maintaining of the project. label Apr 10, 2024
@charliescheer charliescheer added this to the Future milestone Apr 10, 2024
@charliescheer charliescheer self-assigned this Apr 10, 2024
Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super!!

:shipit:

@charliescheer charliescheer merged commit 56dbbf3 into trunk Apr 11, 2024
8 checks passed
@charliescheer charliescheer deleted the fix-depreciation-notice-in-rake-file branch April 11, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Related to anything that supports the building & maintaining of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants