Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update palette to Color Studio 2.5.0 and update WordPress Log In button #1520

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

mrpolanco
Copy link
Contributor

…on design

Fix

Fixes #1186

Four updates included:

  1. Updates the palette to the latest Color Studio (2.5.0) where needed (only Blue and Celadon colors needed updating).
  2. Removes references to deprecated WordPress Blue, replacing them with equivalent Blue colors.
  3. Updates the "Log in with WordPress.com" button to the new design.
  4. Updates the "Log in with email" color from the deprecated WordPress Blue to the new Blue color.

This is the current state:

Log In Flow - iPhone SE (2nd generation)-side

This is the requested design:

109807590-64ff8180-7c26-11eb-9dbb-52f52a919eea

Test

To test, follow these steps:

  1. Log out (if needed).
  2. From the opening screen, click on the "Log In" button to bring up the Action Sheet.
  3. Compare the new design to the current design above.

Tested on iPhones:

  • SE 2nd Gen
  • 14 Pro

New - iPhone SE (2nd generation) - 14 Pro

Review

Only one developer and one designer are required to review these changes, but anyone can perform the review.

Release

These changes do not require release notes.

Observation

The design appears to call for more pronounced rounded corners for buttons (8.0). Kept it at the UIKit default (4.0) as it matches the style of the button on the login screen.

@mrpolanco mrpolanco requested a review from jleandroperez March 23, 2023 23:41
@mrpolanco mrpolanco added enhancement Improve existing functionality. [feature] login Anything relating to login. labels Mar 23, 2023
@peril-automattic
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@mrpolanco mrpolanco requested a review from charliescheer March 27, 2023 14:55
@mrpolanco
Copy link
Contributor Author

Upon further review, it seems like changing the current corner radius (4) of all authentication buttons to match the style suggested in the original request (8) is the correct approach. This also has the benefit of being consistent with the WordPress iOS app, as seen below:

Style - iPhone 14 Pro

Refactored committed code to keep change consistent across login buttons.

@mrpolanco mrpolanco added this to the 4.49 milestone Mar 27, 2023
@mrpolanco mrpolanco requested review from eshurakov and jleandroperez and removed request for jleandroperez and charliescheer March 27, 2023 15:12
@mokagio
Copy link
Contributor

mokagio commented Apr 17, 2023

Hi @mrpolanco 👋 Thank you so much for your contribution! Love the effort you put into aligning things 🙇‍♂️

I just wanted to note that I'll be starting the code freeze process for the 4.49 build and will not include the PR, because it has yet to be reviewed. On the other hand, your other PR #1518 and #1522 will so reach the users 🕺 💃

@mokagio mokagio modified the milestones: 4.49 ❄️, 4.50 Apr 18, 2023
@jleandroperez jleandroperez removed their request for review November 8, 2023 03:10
@spencertransier spencertransier modified the milestones: 4.50, Future Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality. [feature] login Anything relating to login.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ColorStudio and "Log In With WordPress.com" button
3 participants