Add background color to code block in dark mode preview #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrpolanco
added
bug
jleandroperez
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
This PR fixes #1372
When using dark mode, the preview note option on the web app shows a dark color scheme for code blocks. The same does not happen when previewing the note from the iOS app. This fix adds a background color to dark mode that matches the same color as found on the web app (#002b36).
Test
Review
Release
Observation
This addresses the code block background color not matching the web app (#002b36).
To add a color scheme similar to that of the web app, it may be worth adding syntax highlighting to the app's roadmap, if not already done so.