Fix javascript error on log out #2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belcherj
approved these changes
May 4, 2021
|
This went into the release branch after beta1 shipped. Should we ship a new beta? From the milestone list I can see there's nothing else open, so I'd say yes, but thought I'd check first. I'm asking because shipping a new beta involves a bit of manual labor still, so just trying to be efficient 😄 cc @pachlava |
|
👍 thanks @sandymcfadden |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Fixes #2888
When setting the Electron
nativeThemewith the theme selected in the Simplenote settings it can cause a JavaScript error if the theme setting isn't present, such as when logging out of the app.This checks to ensure the theme setting is set before updating the Electron
nativeThemesetting.Test
Release
NA