Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScript error on logout #2888

Closed
pachlava opened this issue May 4, 2021 · 1 comment
Closed

JavaScript error on logout #2888

pachlava opened this issue May 4, 2021 · 1 comment
Labels
bug Something isn't working [feature] login Anything relating to login.

Comments

@pachlava
Copy link
Contributor

pachlava commented May 4, 2021 •
edited
Loading

Expected

Logging out should not cause a JavaScript error.

Observed

It does:
Screenshot 2021-05-04 at 12 44 18
Screenshot 2021-05-04 at 12 44 55

Reproduced

  1. Be logged in
  2. Log out

Where did you see the bug

  • System Make: MBP 16"
  • OS: Win10 (Parallels) | Big Sur 11.2.3
  • Simplenote app version: desktop 2.11.0-beta1
@pachlava pachlava added bug Something isn't working [feature] login Anything relating to login. labels May 4, 2021
@sandymcfadden sandymcfadden mentioned this issue May 4, 2021
Merged
sandymcfadden added a commit that referenced this issue May 4, 2021
@sandymcfadden
Check to ensure theme setting is preset before setting electron nativ…
97547db 
…e theme (#2890)

Fixes #2888

When setting the Electron nativeTheme with the theme selected in the Simplenote settings it can cause a JavaScript error if the theme setting isn't present, such as when logging out of the app.

This checks to ensure the theme setting is set before updating the Electron nativeTheme setting.
@sandymcfadden
Copy link
Contributor

Fixed in #2890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working [feature] login Anything relating to login.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sandymcfadden @pachlava