Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update icons #2158

Merged
merged 3 commits into from
Jun 22, 2020
Merged

Update icons #2158

merged 3 commits into from
Jun 22, 2020

Conversation

codebykat
Copy link
Member

@codebykat codebykat commented Jun 17, 2020 •
edited
Loading

Fix

  • Update all icons in the following locations to the new Simplenote Blue
  • Remove unused sync favicons (added in Add favicons. #22 and never used AFAICT)
  • Move favicon.ico into the resources folder and update webpack config

Test

Build apps and make sure all old blues are gone

Release

Not updated: Updated app icons with new Simplenote Blue

@codebykat codebykat mentioned this pull request Jun 17, 2020
Merged
@codebykat codebykat marked this pull request as ready for review June 18, 2020 02:05
belcherj
belcherj approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@belcherj belcherj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@codebykat codebykat self-assigned this Jun 22, 2020
@codebykat codebykat added this to the 1.20 milestone Jun 22, 2020
@codebykat codebykat merged commit bd2d59a into develop Jun 22, 2020
@codebykat codebykat deleted the update/icons branch June 22, 2020 19:18
@codebykat codebykat mentioned this pull request Dec 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belcherj belcherj belcherj approved these changes

Assignees

@codebykat codebykat

Labels
None yet
Projects
None yet
Milestone
1.20
Development

Successfully merging this pull request may close these issues.
2 participants
@codebykat @belcherj