Updates electron and associated dependencies to the latest #2102
Conversation
belcherj
changed the title
|
@belcherj This is a good start! Simplenote currently doesn't have spellchecking as a preference (or does it?). In order to enable spellchecking, you'll need to toggle |
|
|
|
|
|
Fixed the above issues |
belcherj
force-pushed
the
update/electron
branch
from
14c9a32 to
e00df89
Compare
There was a problem hiding this comment.
When I try to logout, it hangs on "Logging out...", console shows this crash:
boot.ts?1649:24 Uncaught (in promise) ReferenceError: require is not defined
at eval (boot.ts?1649:24)
at new Promise (<anonymous>)
at clearStorage (boot.ts?1649:13)
at eval (boot.ts?1649:99)
at eval (middleware.ts?2ac7:97)
Otherwise this tests okay and the code looks good. Small question about the icon change.
| // Create the browser window. | ||
| const iconPath = path.join( | ||
| __dirname, | ||
| '../lib/icons/app-icon/icon_256x256.png' |
There was a problem hiding this comment.
Does this mean this icon is now unused, or is it being loaded somewhere else? I would like to remove it if possible (see #2158)
|
Still getting a hang on logout, but without any console errors now :/ |
| @@ -52,7 +52,7 @@ PUBLISH ?= onTag | |||
| # Main targets | |||
| .PHONY: start | |||
| start: | |||
| @NODE_ENV=$(NODE_ENV) DEV_SERVER=$(DEV_SERVER) npx electron . | |||
| @NODE_ENV=$(NODE_ENV) DEV_SERVER=$(DEV_SERVER) npx electron . --inspect | |||
There was a problem hiding this comment.
Did you intend to leave this debugging in for start and not just dev? Not sure if I am reading it right.
There was a problem hiding this comment.
I left it there on purpose.
There was a problem hiding this comment.
why?
also why did we remove rebuild-deps?
Fix
Should fix: #2031
Test