Move viewing revisions logic to redux #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
added a commit
that referenced
this pull request
Feb 12, 2020
This patch introduces a new set utility library for adding, removing, and toggling values in a set to make a working "option bag." It also changes the `visiblePane` state from a list of strings into this new option bag, removing the reliance on the `lodash` equivalent functions for using the array. This is meant to be precursor work for #1901 and #1903
belcherj
force-pushed
the
refactor/move-viewing-revisions-logic-to-redux
branch
from
283e8e0 to
0c1983a
Compare
belcherj
force-pushed
the
refactor/move-viewing-revisions-logic-to-redux
branch
from
71c9242 to
37f9321
Compare
dmsnell
reviewed
Feb 17, 2020
| @@ -1,5 +1,5 @@ | |||
| import React, { Component } from 'react'; | |||
| import { connect } from 'react-redux'; | |||
| import { connect, DispatchProp } from 'react-redux'; | |||
There was a problem hiding this comment.
This inclusion was probably unintended.
dmsnell
reviewed
Feb 17, 2020
| @@ -86,7 +86,15 @@ const showNoteInfo: A.Reducer<boolean> = (state = false, action) => { | |||
|
|
|||
| case 'App.toggleNavigation': | |||
| return false; | |||
| default: | |||
| return state; | |||
| } | |||
There was a problem hiding this comment.
maybe belongs in another PR? It looks like we introduced this bug and didn't notice it because undefined collapses into false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Move viewing revisions logic to redux.
Test