Move showTrash from appState to Redux #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
reviewed
Feb 12, 2020
dmsnell
reviewed
Feb 12, 2020
dmsnell
reviewed
Feb 12, 2020
There was a problem hiding this comment.
Trash is an odd view. It's not globally boolean, since obviously the tag drawer needs to be open in order to see it. It's not a tag even though it acts like one. It's not really a pane so it's surprising to see it in visiblePanes
Did you consider putting it anywhere else? It's somewhat of a global mode since it governs the buttons too. What do you think would be the tradeoffs of keeping it as a global boolean?
dmsnell
added a commit
that referenced
this pull request
Feb 12, 2020
This patch introduces a new set utility library for adding, removing, and toggling values in a set to make a working "option bag." It also changes the `visiblePane` state from a list of strings into this new option bag, removing the reliance on the `lodash` equivalent functions for using the array. This is meant to be precursor work for #1901 and #1903
belcherj
force-pushed
the
refactor/show-trash-state-to-redux
branch
from
d14afd2 to
ae5eefb
Compare
dmsnell
reviewed
Feb 13, 2020
belcherj
force-pushed
the
refactor/show-trash-state-to-redux
branch
from
ae5eefb to
0f65ce5
Compare
dmsnell
reviewed
Feb 17, 2020
belcherj
force-pushed
the
refactor/show-trash-state-to-redux
branch
from
ad6afca to
a6b46fb
Compare
belcherj
force-pushed
the
refactor/show-trash-state-to-redux
branch
from
899532c to
74d6742
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Requires: #1866 for
CREATE_NOTETest
We do need
CREATE_NOTEsince you can create a new note from the system menu in Electron