Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node version in CI #1842

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Bump node version in CI #1842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ references:
jobs:
build:
docker:
- image: circleci/node:10.16.3
- image: circleci/node:10.15.0
shell: /bin/bash --login
working_directory: ~/simplenote
steps:
Expand All @@ -52,7 +52,7 @@ jobs:

linux:
docker:
- image: circleci/node:10.16.3
- image: circleci/node:10.15.0
working_directory: ~/simplenote
steps:
- checkout
Expand Down
13 changes: 6 additions & 7 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
environment:
CSC_ENC_KEY:
CSC_ENC_KEY:
secure: ef2yQX3A9dZPQzS6r7oY7pUtzK/ICiUUDZZsh/K7eT59a4BVdxqCfIZU812MmqQHK/iC4cYLdTW+tWHrq9bJquzQgHGjgB0cTBwS9KUjyOg=
CSC_KEY_PASSWORD:
secure: Sz53shy7P4kPzBKa9shHTw==
Expand All @@ -17,7 +17,7 @@ configuration:
- AppX-Testing

install:
- ps: Install-Product node 10
- ps: Install-Product node 11.15.0
- cinst make
- npm ci
- patch -p1 < ./resources/macos/macPackager-patch.diff
Expand All @@ -28,7 +28,7 @@ for:
- matrix:
only:
- configuration: Default
before_build:
before_build:
- openssl aes-256-cbc -d -in .\resources\certificates\win.p12.enc -out %CSC_LINK% -k "%CSC_ENC_KEY%"
- openssl aes-256-cbc -d -in .\resources\secrets\config.json.enc -out .\config.json -k "%CSC_ENC_KEY%"
build_script:
Expand All @@ -44,7 +44,7 @@ for:
- openssl aes-256-cbc -d -in .\resources\secrets\config.json.enc -out .\config.json -k "%CSC_ENC_KEY%"
skip_non_tags: true
environment:
CSC_LINK: ""
CSC_LINK: ''
build_script:
- make build
- make test
Expand All @@ -54,7 +54,7 @@ for:
- matrix:
only:
- configuration: AppX-Testing
before_build:
before_build:
- openssl aes-256-cbc -d -in .\resources\certificates\win.p12.enc -out %CSC_LINK% -k "%CSC_ENC_KEY%"
- openssl aes-256-cbc -d -in .\resources\secrets\config.json.enc -out .\config.json -k "%CSC_ENC_KEY%"
build_script:
Expand All @@ -72,7 +72,6 @@ cache:
- '%APPDATA%\npm-cache'
- C:\ProgramData\chocolatey\bin -> appveyor.yml
- C:\ProgramData\chocolatey\lib -> appveyor.yml

# RDP Debug mode
# on_finish:
# - ps: $blockRdp = $true; iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/appveyor/ci/master/scripts/enable-rdp.ps1'))
# - ps: $blockRdp = $true; iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/appveyor/ci/master/scripts/enable-rdp.ps1'))
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
"url": "git://github.com/Automattic/simplenote-electron.git"
},
"engines": {
"node": ">= 7.9.0",
"npm": ">= 6.4.0"
"node": ">= 10.15.0",
"npm": ">= 6.7.0"
},
"browserslist": [
"> 1%",
Expand Down