Bump node version in CI #1842
Merged
Bump node version in CI #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our AppVeyor builds have been failing due to an issue with `node-gyp`. In this patch we're updating the version of node run in the CI environments. This not only addresses the `node-gyp` issue but it also keeps us more up to date with node.
belcherj
added a commit
that referenced
this pull request
Jan 20, 2020
The builds on AppVeyor have been failing. This should resolve the issue. See this PR for more detail: #1842
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our AppVeyor builds have been failing due to an issue with
node-gyp. In thispatch we're updating the version of node run in the CI environments. This not
only addresses the
node-gypissue but it also keeps us more up to date withnode.
Testing
Most affected by these changes will be the packaged apps.
Once CI finishes, download the built binaries and make sure they run fine.
Any problem would likely result in catastrophic failure - failure to build.