Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets babel compact option to false is development #1806

Merged
merged 2 commits into from
Jan 9, 2020
Merged

Sets babel compact option to false is development #1806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9432b3b
Sets babel compact option to false is development
belcherj Jan 3, 2020
d44995d
Added release note
belcherj Jan 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
- Maintenance cleanups [#1796](https://github.com/Automattic/simplenote-electron/pull/1796), [#1797](https://github.com/Automattic/simplenote-electron/pull/1797), [#1808](https://github.com/Automattic/simplenote-electron/pull/1808), [#1809](https://github.com/Automattic/simplenote-electron/pull/1809), [#1810](https://github.com/Automattic/simplenote-electron/pull/1810), [#1811](https://github.com/Automattic/simplenote-electron/pull/1811)
- Updated dependencies [#1802](https://github.com/Automattic/simplenote-electron/pull/1802)
- Updated dependencies [#1821](https://github.com/Automattic/simplenote-electron/pull/1821)
- Fixed build warning [#1806](https://github.com/Automattic/simplenote-electron/pull/1806)

## [v1.13.0]

Expand Down
3 changes: 3 additions & 0 deletions babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ module.exports = function(api) {
'@babel/plugin-syntax-dynamic-import',
];
const env = {
development: {
compact: false,
},
test: {
plugins: ['dynamic-import-node'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be here too?

what if we turned it off but added it in production? is there any place other than production to turn it on?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My feeling is that we should run the tests on compact.

},
Expand Down