Sets babel compact option to false is development #1806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmsnell
reviewed
Jan 3, 2020
| @@ -18,6 +18,9 @@ module.exports = function(api) { | |||
| '@babel/plugin-syntax-dynamic-import', | |||
| ]; | |||
| const env = { | |||
| development: { | |||
| compact: false, | |||
| }, | |||
| test: { | |||
| plugins: ['dynamic-import-node'], | |||
There was a problem hiding this comment.
should it be here too?
what if we turned it off but added it in production? is there any place other than production to turn it on?
There was a problem hiding this comment.
My feeling is that we should run the tests on compact.
Babel was outputting warnings about lodash and react-dom that it wasn't removing white space. This sets babel compact to false in order to stop those warnings. We also don't need babel to compact in development. https://babeljs.io/docs/en/options#compact
belcherj
force-pushed
the
update/dev-compact-false
branch
from
9f689be to
d44995d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Babel was outputting warnings about lodash and react-dom that it wasn't
removing white space. This sets babel compact to false in order to stop those
warnings. We also don't need babel to compact in development.
https://babeljs.io/docs/en/options#compact
Test
Does the app build from
npm run dev?Review
Only one developer is required to review these changes, but anyone can perform the review.
Release
RELEASE-NOTES.txtwas updated with: