Blocked: Update electron to v6 #1633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 7, 2019
|
@belcherj I'm closing this for branch maintenance. you are welcome to re-open it if you want. my thinking is that we will end up with a similar PR when it's time to do the Electron update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
This PR is to track the upgrade path to electron v6. It is currently blocked by node-spellchecker not compiling on node 12. Electron v6 requires node 12.
Related links:
Test
npm run devReview
Only one developer is required to review these changes, but anyone can perform the review.
Release
Will add release notes when we get to the point where this is mergable.