-
Notifications
You must be signed in to change notification settings - Fork 108
Unable to compile for [email protected] #112
Comments
Same for 5.0.0-beta.7. Any chance to get working version before electron 5.x will be released (target is April 23)? |
same for electron 4.1 :( |
I fixed it by rebuilding the module: https://electronjs.org/docs/tutorial/using-native-node-modules |
@AlexandreKilian I guess you fixed it for electron 4.1.x. Right? For version 5.x.x it won't work. Module itself contain V8::Handle, that was deprecated. There is simple change needed to make it work and I believe electron team aware of it. See: https://electronjs.org/blog/nodejs-native-addons-and-electron-5 |
yes, sorry, for 4.1.x |
@nathansobo any chance to resolve issue with deprecated methods? Electron 5 already released. |
We ourselves are behind on Electron versions and somewhat overwhelmed with other tasks. If someone wants to open a PR I'll review it, otherwise we'll get to this when we have bandwidth. |
@nathansobo pull request is already exist: #108 |
electron-rebuild output:
The text was updated successfully, but these errors were encountered: