Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/update all transactional email templates #3075

Merged

Conversation

chickenn00dle
Copy link
Contributor

@chickenn00dle chickenn00dle commented Apr 20, 2024

All Submissions:

Changes proposed in this Pull Request:

This PR updates the remaining transactional email template designs to match the updates done to the OTP email (#3032, #3033, and #3034)

Account verification:
Screenshot 2024-04-22 at 17 22 27

Reset password:
Screenshot 2024-04-22 at 17 22 04

Receipt:
Screenshot 2024-04-22 at 17 21 57

Account deletion:
Screenshot 2024-04-22 at 17 22 10

Subscription/Donation cancellation:
Screenshot 2024-04-22 at 17 21 46

(OTP will have already been updated at this point)

Note: I believe we will be removing the Magic Link template in favor of always using the OTP. At least based on the Figma here: https://www.figma.com/file/c6T1goPQpkchdh7XBAM6aH/Reader-Activation-System?type=design&node-id=1589-35127&mode=design&t=1gF6i52UIhsMYAk3-0

I will confirm this and remove in a follow-up PR if this is the case. Regardless, I've updated the design for this template in this PR anyway, but currently there is no way to trigger it via the UI.

How to test the changes in this Pull Request:

  1. Go to Newspack > Engagement > Show Advanced Settings > Transactional Email Content, then trash each of the emails shown here via the edit button (should be every one mentioned above except for the receipt template). This is so our default templates can be used for emails.
  2. Go to Newspack > Reader Revenue > Emails, then trash the receipt email via the edit button.
  3. Trigger each of the emails, then view them and verify they look as pictured above. You can trigger each email as follows:
  • Account verification - As a logged out user, sign up for a new account. Once logged in, go to My Account and select the Send me a link option to send a verification email
  • Password reset - Once verified, go back to My Account and select the Create a Password link
  • Receipt - Purchase a donation via the donation block. You will need to set up the block on any post or page to do this
  • Account deletion - Go to My Account and select the Delete Account button
  • Receipt - Purchase a recurring donation or subscription product
  • Subscription/Donation Cancellation - Cancel the recurring donation or subscription via My Account

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@chickenn00dle chickenn00dle force-pushed the feat/update-all-transactional-email-templates branch from 1a014f1 to c741ed7 Compare April 20, 2024 19:59
@chickenn00dle chickenn00dle marked this pull request as ready for review April 20, 2024 20:03
@chickenn00dle chickenn00dle requested a review from a team as a code owner April 20, 2024 20:03
@chickenn00dle chickenn00dle added [Status] Needs Review The issue or pull request needs to be reviewed wip and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Apr 20, 2024
@chickenn00dle
Copy link
Contributor Author

Taking this back to WIP since I was looking at the wrong email designs 🤦

@chickenn00dle chickenn00dle force-pushed the feat/update-all-transactional-email-templates branch from c2f8d07 to 10860e4 Compare April 22, 2024 21:08
@chickenn00dle chickenn00dle added [Status] Needs Review The issue or pull request needs to be reviewed and removed wip labels Apr 22, 2024
@chickenn00dle
Copy link
Contributor Author

Ready for review again.

Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found a bug when testing, but it's not introduced by this PR. Noted here: #3056 (review).

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Apr 25, 2024
@chickenn00dle chickenn00dle merged commit 1570790 into epic/ras-acc Apr 25, 2024
8 checks passed
@chickenn00dle chickenn00dle deleted the feat/update-all-transactional-email-templates branch April 25, 2024 13:40
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.8.0-epic-ras-acc.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.9.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.1.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.2.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 4.4.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @epic/ras-acc [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants