feat(ras-acc): add donation cancellation email template

[chickenn00dle]

All Submissions:

• Have you followed the Newspack Contributing guideline?
• Does your code follow the WordPress' coding standards and VIP Go coding standards?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes proposed in this Pull Request:

Closes https://app.asana.com/0/1206810965479792/1205743341940640/f

This PR adds a new donation cancellation email:

Note: I've populated the cancellation email with super basic copy based mostly off of the email template for receipt. Since we are revisiting email design in ras-acc and this is going into epic/ras-acc, I think this is fine for now. If it's alright, I'd like to address updating the email content if necessary in https://app.asana.com/0/1205234045751551/1205668937699542/f where we will be updating all transactional emails. Scratch that, I found the copy for this here https://newspackdesignp2.wordpress.com/2023/12/05/cancellation-emails/. I will still be addressing the design updates in another pr, so this PR only gets the email setup with the old design.

How to test the changes in this Pull Request:

1. Go to Newspack > Reader Revenue > Emails
2. Confirm a new Cancellation email is present as pictured above
3. Select the edit link
4. Confirm the email template post is populated with content relevant to donation cancellation
5. Make some changes to the post and update
6. Go back to the reader revenue emails menu
7. Select the reset link for the Cancellation email
8. Select the edit link once again and confirm your changes have been reset to default
9. As a reader, trigger a donation cancellation email by purchasing a recurring donation then cancelling via my account
10. Confirm you receive a cancellation email and its contents appear as expected (pictured above)
11. As a site admin, disable the cancellation email and repeat step 9
12. Confirm no cancellation email is sent

Other information:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes, as applicable?
• Have you successfully ran tests with your changes locally?

[adekbadek]

Pre-approving pending a small tweak.

[adekbadek]

This should rather be the other way around – if the type is receipt, use the message about the default receipt. Otherwise, use the generic message.

[chickenn00dle]

This should rather be the other way around – if the type is receipt, use the message about the default receipt. Otherwise, use the generic message.

Do you mean this should be changed to:

const notification =
    email.type === 'receipt'
        ? __(
            'This email is not active. The default receipt will be used.',
	    'newspack-plugin'
            )
        : __( 'This email is not active.', 'newspack-plugin' );

If so, this will have the same result as the current changes. On my end, it looks like the messaging is correct on the frontend as well:

Or did you mean something else?

[adekbadek]

That's what I meant. The result is the same, but the code is more logical.

[chickenn00dle]

I see. Happy to make the change if you feel that way! Done in 052255f

[adekbadek]

It's not about feelings, it's logic & readability:

type === 'receipt' ? notification_about_receipt : generic_notification

instead of

type === 'cancellation' ?  generic_notification : notification_about_receipt

As long as type can only be 'receipt' or 'cancellation' the former version seems fine, but it's not a good assumption to build on (there will be other types).

[matticbot]

🎉 This PR is included in version 3.6.0-epic-ras-acc.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[adekbadek]

Since this is an epic branch, I did not submit an issue for this. But let me know if there's a better way.

[adekbadek]

When deleting and account which has active subscriptions, this method will throw with

PHP Fatal error:  Uncaught Error: Call to a member function get_product_id() on null

because the $item is null at this point.

[chickenn00dle]

Thanks for catching this! I'll get a fix up for this today 👍

[matticbot]

🎉 This PR is included in version 3.9.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 4.1.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 4.2.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[matticbot]

🎉 This PR is included in version 4.4.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀