Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid a reCAPTCHA API error when script is enqueued with a version param #2943

Merged
merged 2 commits into from
Feb 21, 2024
Merged

fix: avoid a reCAPTCHA API error when script is enqueued with a version param #2943

merged 2 commits into from
Feb 21, 2024

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Feb 21, 2024

All Submissions:

Changes proposed in this Pull Request:

Fixes a regression introduced by #2843.

How to test the changes in this Pull Request:

  1. On release, configure reCAPTCHA in the Newspack > Connections wizard.
  2. On the front-end, try to submit a form protected by reCAPTCHA (such as the Newsletter Subscription Form)
  3. Observe a JS console error that prevents form submission: Uncaught Error: Invalid site key or not loaded in api.js
  4. Check out this branch, refresh, repeat, and confirm the form submits.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo requested a review from a team as a code owner February 21, 2024 22:58
@dkoo dkoo self-assigned this Feb 21, 2024
@dkoo dkoo added the [Status] Needs Review The issue or pull request needs to be reviewed label Feb 21, 2024
claudiulodro
claudiulodro approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@claudiulodro claudiulodro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks for resolving so quickly!

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Feb 21, 2024
@dkoo dkoo merged commit c7d8bff into release Feb 21, 2024
5 of 7 checks passed
@dkoo dkoo deleted the fix/recaptcha-site-key branch February 21, 2024 23:06
matticbot pushed a commit that referenced this pull request Feb 21, 2024
@semantic-release-bot
chore(release): 3.1.1 [skip ci]
331bd84 
## [3.1.1](v3.1.0...v3.1.1) (2024-02-21)

### Bug Fixes

* avoid a reCAPTCHA API error when script is enqueued with a version param ([#2943](#2943)) ([c7d8bff](c7d8bff))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiulodro claudiulodro claudiulodro approved these changes

Assignees

@dkoo dkoo

Labels
released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkoo @matticbot @claudiulodro