Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to PHPCS #2843

Merged
merged 7 commits into from
Jan 30, 2024
Merged

Updates to PHPCS #2843

merged 7 commits into from
Jan 30, 2024

Conversation

adekbadek
Copy link
Member

@adekbadek adekbadek commented Jan 8, 2024 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Updates PHPCS packages to latest, fixes or ignores the new violations.

How to test the changes in this Pull Request:

Smoke test, nothing should change functionally with this changeset.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Jan 8, 2024
@adekbadek adekbadek requested a review from a team as a code owner January 8, 2024 10:52
@leogermani
Copy link
Contributor

@adekbadek if you refresh this PR to fix conflicts I promise to have a quick look at it !

@adekbadek
Copy link
Member Author

@leogermani – done! I'll hold you to your promise ;)

leogermani
leogermani approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@leogermani leogermani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed one commit and all looks good

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Jan 30, 2024
@adekbadek adekbadek merged commit 4d53e2e into master Jan 30, 2024
6 checks passed
@adekbadek adekbadek deleted the chore/phpcs branch January 30, 2024 17:37
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-epic-test-release-workflow.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.1.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.1.0-epic-ras-acc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dkoo dkoo mentioned this pull request Feb 21, 2024
Merged
6 tasks
@adekbadek adekbadek mentioned this pull request Nov 11, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogermani leogermani leogermani approved these changes

Assignees
No one assigned
Labels
released on @alpha released on @epic/ras-acc released on @epic/test-release-workflow released [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adekbadek @leogermani @matticbot