-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aggregation): add $fill pipeline stage #12545
feat(aggregation): add $fill pipeline stage #12545
Conversation
densify pipeline stage was not in the union type for PipelineStage, this was causing ts error when users where trying to call aggregate method with densify stage
…ing-densify-stage-on-pipeline-stages-type Add missing densify type pipeline type
replaceWith pipeline stage was not accepting a field as a parameter. This was causing ts error when users where trying to call aggregate method with replaceWith stage in unusual ways
docs(guide): update broken read-preference links
docs(connection): improved useDb() documentation
…eplace-with-stage-on-pipeline-stages-type Adjust replaceWith type pipeline stage
…late chore(template::bug): add field for typescript version
Automatticgh-12536: add tests revert some remove operators enhance type fix example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
@@ -111,11 +111,11 @@ Aggregate.prototype.model = function(model) { | |||
this._model = model; | |||
if (model.schema != null) { | |||
if (this.options.readPreference == null && | |||
model.schema.options.read != null) { | |||
model.schema.options.read != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the future, please avoid making these sort of minor style changes. They make it harder to review your code.
Summary
Fixes: #12536
Adds
$fill
aggregation pipeline stage.https://docs.mongodb.com/manual/reference/operator/aggregation/fill/
Adds
$linearFill
and$locf
WindowOperator'shttps://www.mongodb.com/docs/manual/reference/operator/aggregation/linearFill/
https://www.mongodb.com/docs/manual/reference/operator/aggregation/locf