Add missing densify type pipeline type #12533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
densify pipeline stage was not in the union type for PipelineStage, this was causing ts error when users where trying to call aggregate method with densify stage
nicotsx
approved these changes
Oct 6, 2022
|
This is the same for the $fill stage |
AbdelrahmanHafez
approved these changes
Oct 6, 2022
AbdelrahmanHafez
added
the
typescript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
densify pipeline stage was not in the union type
for PipelineStage, this was causing ts error when
users were trying to call the aggregate method with
densify stage
Summary
After declaring a model and using its
.aggregationmethod with a$densifystage, I received an error related to the fact that there was no method overload matching a pipeline with$densifyas a stage.Looking at the
PipelineStagetype, I saw thatPipelineStage.Densifywas missing in the union type.So I just added it.
Examples
The following was causing an error, now it's allowed.