Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect: Integrate ScanReport #40420

Merged
merged 159 commits into from
Dec 11, 2024
Merged

Protect: Integrate ScanReport #40420

merged 159 commits into from
Dec 11, 2024

Conversation

dkmyta
Copy link
Contributor

@dkmyta dkmyta commented Dec 2, 2024 •
edited
Loading

Description

Adds ScanReport to the Home page in Protect

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Checkout this branch load Protect in JT
  • Ensure you are redirected to the Home tab after passing setup
  • Review the various states of the HomeStatCards error, scanning, idle, disabled
  • Verify that the ScanReport appropriately reflects the state of the site
  • Ensure no regressions are introduced

Screenshots

Screen Shot 2024-12-02 at 13 59 11

nateweller and others added 30 commits November 21, 2024 15:35
@nateweller
Init project branch
997e0b1
@dkmyta @nateweller
Protect: Add Go to Cloud and Scan now button to Protect primary header (
c6c82a9 
#40057)

Co-authored-by: Nate Weller <[email protected]>
@dkmyta @nateweller
Protect: Update Scan and History headers (#40058)
fc04ac5 
* Update Scan and History section header structure/content

* changelog

* Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx

Co-authored-by: Nate Weller <[email protected]>

---------

Co-authored-by: Nate Weller <[email protected]>
@nateweller
Protect: de-emphasize cloud link by using link variant (#40211)
fb3582e
@dkmyta
Add home tab, page and stat cards
ad120a9
@dkmyta
Fixes and improvements
d210012
@dkmyta
Add Tooltips
b07220c
@dkmyta
Fix translations
3613c64
@dkmyta
Reorg
f95141c
@dkmyta
Fix typo
88b0977
@dkmyta
Add errorMessage flag to StatCard, make WAF stats free
7840094
@dkmyta
changelog
0a5ba31
@dkmyta
Add icon labels
0b17531
@dkmyta
Remove error class
3ab4126
@dkmyta
Use ToggleControl
1b12f91
@dkmyta
Remove imports
b425656
@dkmyta
Improve responsiveness of header and stat cards
93295fe
@dkmyta
Fix subheading text wrap
5ab6db3
@dkmyta
Add StatCard error flag
c636037
@dkmyta
Fix WAF settings toggles
3c928b2
@dkmyta
Optimizations
4a870d1
@dkmyta
Centralize localTimestamp
2eb89b4
@dkmyta
Add scanning card state
621b15c
@dkmyta
Fix styling
b908e37
@dkmyta
Update scanning card state
95d2e1e
@nateweller
Init project branch
fd712cc
@dkmyta @nateweller
Protect: Add Go to Cloud and Scan now button to Protect primary header (
01c637d 
#40057)

Co-authored-by: Nate Weller <[email protected]>
@dkmyta @nateweller
Protect: Update Scan and History headers (#40058)
b0a9819 
* Update Scan and History section header structure/content

* changelog

* Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx

Co-authored-by: Nate Weller <[email protected]>

---------

Co-authored-by: Nate Weller <[email protected]>
@nateweller
Protect: de-emphasize cloud link by using link variant (#40211)
05bae76
@dkmyta
Update scanning card tooltip
b9a2980
Base automatically changed from add/protect/home to add/protect/core December 10, 2024 21:25
nateweller
nateweller requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@nateweller nateweller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple small comments and questions, but looks great 👍

@dkmyta dkmyta requested a review from nateweller December 10, 2024 22:32
@nateweller
Copy link
Contributor

On a new site, when starting for free, there are a couple empty line items in the table prior to the scan status loading. Was too fast to grab a screenshot 😛

@nateweller
Copy link
Contributor

Sorting by version does not work, we could disabled it with the enableSorting prop on the field config.

Screenshot 2024-12-11 at 10 43 03 AM

@nateweller
Copy link
Contributor

The scan tab uses negative margins to align the DataViews table flush with the edge of the screen (code). Should we do the same here?

Screenshot 2024-12-11 at 10 46 11 AM

@nateweller
Copy link
Contributor

nateweller commented Dec 11, 2024 •
edited
Loading

Not blocking: should the stat card icon be red when threats are detected?

Screenshot 2024-12-11 at 10 50 50 AM Screenshot 2024-12-11 at 10 52 00 AM

nateweller
nateweller approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@nateweller nateweller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left minor comments that could be follow-ups if relevant.

@dkmyta
Copy link
Contributor Author

dkmyta commented Dec 11, 2024

On a new site, when starting for free, there are a couple empty line items in the table prior to the scan status loading. Was too fast to grab a screenshot

I am wondering if this might fall in with nicely being addressed with this task? We should probably remain consistent with whatever approach we take there - show prior results or hide the table when we have nothing to show? Or is this a separate issue entirely?

Not blocking: should the stat card icon be red when threats are detected?

This was as per designs, although I am open to the change. Only conflict is that we currently reserve the red icon for the error state in the scan StatCard.

Disabled version field sorting and added negative margins!

@nateweller nateweller merged commit cfebba4 into add/protect/core Dec 11, 2024
64 of 65 checks passed
@nateweller nateweller deleted the update/protect/add-scan-report-to-home branch December 11, 2024 18:17
nateweller pushed a commit that referenced this pull request Dec 11, 2024
@dkmyta @nateweller
Protect: Integrate ScanReport (#40420)
322819d
@nateweller nateweller mentioned this pull request Dec 11, 2024
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nateweller nateweller nateweller approved these changes

Assignees

@dkmyta dkmyta

Labels
[JS Package] Components [JS Package] Scan [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. RNA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkmyta @nateweller