Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect: Update Scan and History headers #40058

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

dkmyta
Copy link
Contributor

@dkmyta dkmyta commented Nov 5, 2024

Description

Updates the Scan and History header structure and content as per designs.

Note: This PR intentionally only address the above tasks, it does not add or remove any content and functionality for the existing UI. Bits and pieces may need addressing (or will be addressed) once the new ThreatsDataViews component is implemented in Protect.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Use the Jetpack Beta Tester using this branch on Protect with a Scan upgrade
  • Ensure the Scan header and the History header display as per designs (Note that you will need to manually visit /scan/history to view the History page as the navigation has been removed in preparation for ThreatsDataViews)
  • Verify that the Show auto fixers button renders (when applicable - fixableThreatsList > 0) and on click displays the appropriate modal
  • Ensure the onboarding popover for the above button renders accordingly
  • Downgrade and ensure that appropriate content render for each
  • Confirm no regressions are introduced

Screenshots

Scanner:
Screen Shot on 2024-11-05 at 10-59-17

History:
Screen Shot on 2024-11-05 at 10-59-45

@github-actions github-actions bot added [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Status] In Progress labels Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Protect plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@dkmyta dkmyta marked this pull request as ready for review November 8, 2024 16:39
@dkmyta dkmyta self-assigned this Nov 8, 2024
@nateweller nateweller force-pushed the update/protect/scan-and-history-headers branch from 2b0997e to 9842bba Compare November 13, 2024 18:59
@nateweller
Copy link
Contributor

nateweller commented Nov 13, 2024

We should stack this on #40076 as it removes the scanner/history navigation from the header 👍

Will involve some breaking rebasing to do that, maybe we circle back after confirming the finalized designs this week?

@nateweller nateweller force-pushed the update/protect/scan-and-history-headers branch from 9842bba to d13b262 Compare November 14, 2024 18:23
@nateweller nateweller changed the base branch from trunk to add/protect/core November 14, 2024 18:23
Copy link
Contributor

@nateweller nateweller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: Stacked this on top of a project branch so we can merge.

LGTM 👍

@dkmyta dkmyta merged commit 1e7a600 into add/protect/core Nov 14, 2024
49 checks passed
@dkmyta dkmyta deleted the update/protect/scan-and-history-headers branch November 14, 2024 19:10
nateweller added a commit that referenced this pull request Nov 19, 2024
* Update Scan and History section header structure/content

* changelog

* Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx

Co-authored-by: Nate Weller <[email protected]>

---------

Co-authored-by: Nate Weller <[email protected]>
nateweller added a commit that referenced this pull request Nov 21, 2024
* Update Scan and History section header structure/content

* changelog

* Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx

Co-authored-by: Nate Weller <[email protected]>

---------

Co-authored-by: Nate Weller <[email protected]>
nateweller added a commit that referenced this pull request Nov 25, 2024
* Update Scan and History section header structure/content

* changelog

* Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx

Co-authored-by: Nate Weller <[email protected]>

---------

Co-authored-by: Nate Weller <[email protected]>
nateweller added a commit that referenced this pull request Nov 26, 2024
* Update Scan and History section header structure/content

* changelog

* Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx

Co-authored-by: Nate Weller <[email protected]>

---------

Co-authored-by: Nate Weller <[email protected]>
nateweller added a commit that referenced this pull request Nov 28, 2024
* Update Scan and History section header structure/content

* changelog

* Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx

Co-authored-by: Nate Weller <[email protected]>

---------

Co-authored-by: Nate Weller <[email protected]>
nateweller added a commit that referenced this pull request Nov 30, 2024
* Update Scan and History section header structure/content

* changelog

* Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx

Co-authored-by: Nate Weller <[email protected]>

---------

Co-authored-by: Nate Weller <[email protected]>
nateweller added a commit that referenced this pull request Dec 2, 2024
* Update Scan and History section header structure/content

* changelog

* Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx

Co-authored-by: Nate Weller <[email protected]>

---------

Co-authored-by: Nate Weller <[email protected]>
nateweller added a commit that referenced this pull request Dec 3, 2024
* Update Scan and History section header structure/content

* changelog

* Update projects/plugins/protect/src/js/routes/scan/scan-admin-section-hero.tsx

Co-authored-by: Nate Weller <[email protected]>

---------

Co-authored-by: Nate Weller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants