[RNMobile] Show "No title"/"No description" placeholder for not belonged videos

[fluiddot]

Follow up on #30759.

Proposed changes:

• For not belonged videos that have an empty title and/or description, instead of displaying the placeholder Add title/Add description, show No title/No description to avoid confusion.

Empty title and description	With title and description

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

N/A

Testing instructions:

• Open a post/page.
• Add a VideoPress block.
• Add a video that doesn't belong to the site and has an empty title and description (e.g. insert the video from an URL - https://videopress.com/v/XBqrRFxJ).
• Open the block settings.
• Observe that the title and description settings are disabled.
• Observe that the title field displays a placeholder with the text No title.
• Observe that the description field displays a placeholder with the text No description.
• Replace the video with another one that doesn't belong to the site, but has a title and description. (e.g. insert the video from an URL - https://videopress.com/v/E6So1Wpf).
• Observe that the title and description settings are disabled.
• Observe that the title field displays the title of the video.
• Observe that the description field displays the description of the video.

[github-actions]

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack rnmobile/videopress-no-description-placeholder

to get started. More details: p9dueE-5Nn-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ All commits were linted before commit.
  
• ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

---

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

[SiobhyB]

@fluiddot, LGTM! Thank you for spotting and following up on this 🙇‍♀️

What do you think about also updating the title placeholder? It'd be a edge case, but an add title placeholder does display when there's no title, which would be confusing if it can't actually be edited.

jetpack/projects/packages/videopress/src/client/block-editor/blocks/video/components/details-panel/index.native.js

Line 31 in 87262ba

placeholder={ __( 'Add title', 'jetpack-videopress-pkg' ) }

[fluiddot]

What do you think about also updating the title placeholder? It'd be a edge case, but an add title placeholder does display when there's no title, which would be confusing if it can't actually be edited.

Yeah, I could apply the same approach to that field too. I'll push an update with this suggestion, thanks!

[fluiddot]

What do you think about also updating the title placeholder? It'd be a edge case, but an add title placeholder does display when there's no title, which would be confusing if it can't actually be edited.

Yeah, I could apply the same approach to that field too. I'll push an update with this suggestion, thanks!

@SiobhyB I applied this suggestion in 9759f0d. Let me know if you could take a look at the PR, thanks 🙇 !

[jhnstn]

Looks good