[not verified] [RNMobile] Show "No title"/"No description" placeholde…

…r for not belonged videos (#31134) * Display no description placeholder for not belonged videos * Display no title placeholder for not belonged videos * Add changelog * Bump package version
Automattic · Jun 8, 2023 · 858d6d1 · 858d6d1
1 parent 9efd16a
commit 858d6d1
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 4 deletions.
diff --git a/projects/packages/videopress/changelog/rnmobile-videopress-no-description-placeholder b/projects/packages/videopress/changelog/rnmobile-videopress-no-description-placeholder
@@ -0,0 +1,4 @@
+Significance: patch
+Type: added
+
+RNMobile: Display no title and no description placeholder for not belonged videos
diff --git a/projects/packages/videopress/package.json b/projects/packages/videopress/package.json
@@ -1,7 +1,7 @@
 {
 	"private": true,
 	"name": "@automattic/jetpack-videopress",
-	"version": "0.14.5",
+	"version": "0.14.6-alpha",
 	"description": "VideoPress package",
 	"homepage": "https://github.com/Automattic/jetpack/tree/HEAD/projects/packages/videopress/#readme",
 	"bugs": {

diff --git a/projects/packages/videopress/src/class-package-version.php b/projects/packages/videopress/src/class-package-version.php
@@ -11,7 +11,7 @@
  * The Package_Version class.
  */
 class Package_Version {
-	const PACKAGE_VERSION = '0.14.5';
+	const PACKAGE_VERSION = '0.14.6-alpha';
 
 	const PACKAGE_SLUG = 'videopress';
 

diff --git a/.../videopress/src/client/block-editor/blocks/video/components/details-panel/index.native.js b/.../videopress/src/client/block-editor/blocks/video/components/details-panel/index.native.js
@@ -19,20 +19,26 @@ import VideoNotOwnedWarning from '../video-not-owned-warning';
  */
 export default function DetailsPanel( { attributes, setAttributes, videoBelongToSite } ) {
 	const { title, description } = attributes;
+	const titlePlaceholder = videoBelongToSite
+		? __( 'Add title', 'jetpack-videopress-pkg' )
+		: __( 'No title', 'jetpack-videopress-pkg' );
+	const descriptionPlaceholder = videoBelongToSite
+		? __( 'Add description', 'jetpack-videopress-pkg' )
+		: __( 'No description', 'jetpack-videopress-pkg' );
 
 	return (
 		<PanelBody title={ __( 'Details', 'jetpack-videopress-pkg' ) }>
 			<TextControl
 				value={ title || '' }
 				onChange={ value => setAttributes( { title: value } ) }
-				placeholder={ __( 'Add title', 'jetpack-videopress-pkg' ) }
+				placeholder={ titlePlaceholder }
 				label={ __( 'Title', 'jetpack-videopress-pkg' ) }
 				disabled={ ! videoBelongToSite }
 			/>
 			<BottomSheetTextControl
 				initialValue={ description }
 				onChange={ value => setAttributes( { description: value } ) }
-				placeholder={ __( 'Add description', 'jetpack-videopress-pkg' ) }
+				placeholder={ descriptionPlaceholder }
 				label={ __( 'Description', 'jetpack-videopress-pkg' ) }
 				disabled={ ! videoBelongToSite }
 			/>