Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPress: update UI/UX when the video block doesn't belong to site #30443

Merged
merged 7 commits into from
May 4, 2023

Conversation

retrofox
Copy link
Contributor

@retrofox retrofox commented May 3, 2023

Fixes #

Proposed changes:

  • VideoPress: update UI/UX when the video block doesn't belong to site

Other information:

  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to the block editor
  • Create/edit a VideoPress video block instance that belongs to the site
  • Confirm everything works as expected
  • Create a new instance but using an external video (https://videopress.com/v/NGYE1Hqy)
  • Confirm the side shows a Notice about it in the Details panel
  • Confirm title and description are disabled
  • Confirm Video frame poster is disabled
  • Confirm all controls of Privacy are disabled
  • Confirm the rest work as expected
Details panel Poster Privacy
image image image
Screen.Recording.2023-05-03.at.17.41.14.mov

@retrofox retrofox added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress [Block] VideoPress [Package] VideoPress labels May 3, 2023
@retrofox retrofox requested a review from a team May 3, 2023 20:42
@retrofox retrofox self-assigned this May 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack update/videopress-add-not-edition-allowed-notice

to get started. More details: p9dueE-5Nn-p2

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@retrofox retrofox force-pushed the update/videopress-add-not-edition-allowed-notice branch from 3d4771e to 425f1c4 Compare May 4, 2023 14:21
Copy link
Contributor

@dhasilva dhasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well 🚀

@retrofox retrofox merged commit 97c2e44 into trunk May 4, 2023
@retrofox retrofox deleted the update/videopress-add-not-edition-allowed-notice branch May 4, 2023 19:37
@fluiddot
Copy link
Contributor

Hey @retrofox 👋 , based on these changes I'm wondering if we could close #29964 as the Privacy and Rating fields are disabled when those settings can't be updated. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] VideoPress [Package] VideoPress [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants