Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opentable: Remove noticeOperations from the useEffect dependencies #19043

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

pablinos
Copy link
Contributor

@pablinos pablinos commented Mar 5, 2021

Changes proposed in this Pull Request:

  • Like Fix instagram infinite loop bug #19034, this fixes the same issue with the Opentable block. Having noticeOperations in the dependency array causes the editor to hang as it gets into a render loop.

Jetpack product discussion

Primary issue: #19038

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Add an Opentable block with Gutenberg 10.1.0 active
  • The editor will hang
  • With this PR, it should work as expected
  • Check that you still receive a notice when the block is not wide or full aligned and the wide style is selected

Proposed changelog entry for your changes:

  • Remove the noticeOperations dependency from the useEffect in the OpenTable block to prevent a loop caused from a change in Gutenberg 10.1.0

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello pablinos! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D58176-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@pablinos pablinos requested a review from jeherve March 5, 2021 11:33
@pablinos pablinos added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Block] OpenTable labels Mar 5, 2021
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Mar 5, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Include a changelog entry for any meaningful change.
  • ✅ Specify whether this PR includes any changes to data or privacy.

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


If you are an automattician, once your PR is ready for review add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.undefined


jetpack plugin:

  • Next scheduled release: April 6, 2021.
  • Scheduled code freeze: March 29, 2021

@retrofox retrofox requested a review from a team March 5, 2021 12:17
@retrofox retrofox added [Pri] High [Type] Bug When a feature is broken and / or not performing as intended labels Mar 5, 2021
Copy link
Contributor

@retrofox retrofox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Confirmed the app got stuck when adding an open table block.

image

After this patch, the block works as expected
image

@jeherve jeherve added this to the 9.5.2 milestone Mar 5, 2021
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 5, 2021
@jeherve jeherve merged commit 3fe9dbe into master Mar 5, 2021
@jeherve jeherve deleted the fix/opentable-hang branch March 5, 2021 12:29
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Mar 5, 2021
jeherve pushed a commit that referenced this pull request Mar 5, 2021
@jeherve
Copy link
Member

jeherve commented Mar 5, 2021

Cherry-picked to jetpack/branch-9.5 in 32f5ddf

@retrofox
Copy link
Contributor

retrofox commented Mar 5, 2021

r222192-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] OpenTable [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] High Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants