Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: conflict between Gutenberg 10.1.0 and multiple Jetpack blocks #19038

Closed
3 tasks done
jeherve opened this issue Mar 5, 2021 · 3 comments
Closed
3 tasks done

Blocks: conflict between Gutenberg 10.1.0 and multiple Jetpack blocks #19038

jeherve opened this issue Mar 5, 2021 · 3 comments
Assignees
@pablinos @glendaviesnz
Labels
[Block] Latest Instagram Posts [Block] OpenTable [Block] Podcast Player Epic Formerly "Primary Issue", or "Master Issue" [Pri] High [Type] Bug When a feature is broken and / or not performing as intended
Milestone
jetpack/9.5.2

Comments

@jeherve
Copy link
Member

jeherve commented Mar 5, 2021 •
edited by pablinos
Loading

The issue is best described in this Gutenberg PR:

WordPress/gutenberg#29491

The problem is currently visible on all sites running the most recent version of Gutenberg (10.1.0, released 2 days ago) and Jetpack. The issue is already fixed in Gutenberg's master, and is currently slated to be pushed out with Gutenberg 10.2.0.

In Jetpack, the Gutenberg ends up impacting multiple blocks:

Steps to reproduce the issue

  1. Start with a site running the Jetpack plugin and the most recent version of the Gutenberg plugin, 10.1.0
  2. Go to Posts > Add New
  3. Try to insert any of the blocks above.
  4. Notice the editor crashing.

Internal references

  • p1614912413220000-slack-C02A41GCS
  • p1614895798108900-slack-CBTN58FTJ
  • p1614929521146100-slack-C45SNKV4Z
  • p1614928145004300-slack-CBG1CP4EN
  • p1614930165108900-slack-CJS75TX3R
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended Epic Formerly "Primary Issue", or "Master Issue" [Pri] High [Block] OpenTable [Block] Podcast Player [Block] Latest Instagram Posts labels Mar 5, 2021
This was referenced Mar 5, 2021
Merged
Merged
@jeherve jeherve added this to the 9.5.2 milestone Mar 5, 2021
@pablinos
Copy link
Contributor

pablinos commented Mar 5, 2021

I've just created this fix for Gutenberg, which should handle all uses of noticeOperations WordPress/gutenberg#29582

@pablinos pablinos mentioned this issue Mar 5, 2021
Merged
@jeherve
Copy link
Member Author

jeherve commented Mar 5, 2021

@pablinos Do you think we can close this now that this will be handled in Gutenberg directly?

@pablinos
Copy link
Contributor

pablinos commented Mar 5, 2021

Yeah I think so. We've merged all the fixes too.

@pablinos pablinos closed this as completed Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pablinos pablinos

@glendaviesnz glendaviesnz

Labels
[Block] Latest Instagram Posts [Block] OpenTable [Block] Podcast Player Epic Formerly "Primary Issue", or "Master Issue" [Pri] High [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
jetpack/9.5.2
Development

No branches or pull requests
3 participants
@pablinos @jeherve @glendaviesnz