Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ads Block: Move mobile toggle to the sidebar #15120

Merged
merged 2 commits into from
Mar 26, 2020
Merged

Ads Block: Move mobile toggle to the sidebar #15120

merged 2 commits into from
Mar 26, 2020

Conversation

rclations
Copy link
Contributor

Moves the "hide on mobile views" toggle to the sidebar, as requested in p58i-8JL-p2.

Testing instructions:

  • Sign up for Jetpack Ads.
  • Place an Ads block on your page.
  • Make sure the "Hide on mobile" toggle appears in your sidebar.

Proposed changelog entry for your changes:

  • Moved Ads block "hide on mobile" toggle to the sidebar.

@rclations rclations added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Feature] WordAds [Feature] WordPress.com Block Editor labels Mar 25, 2020
@rclations rclations requested review from dbspringer, cphilleo, phpmypython and a team March 25, 2020 20:05
@rclations rclations self-assigned this Mar 25, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello rclations! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D40854-code before merging this PR. Thank you!

@jetpackbot
Copy link

jetpackbot commented Mar 25, 2020 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 7, 2020.
Scheduled code freeze: March 31, 2020

Generated by 🚫 dangerJS against f018858

@dbspringer
Copy link
Member

Looks good 👍
Screen Shot 2020-03-25 at 3 58 25 PM

dbspringer
dbspringer previously approved these changes Mar 25, 2020
View reviewed changes
@dbspringer dbspringer added this to the 8.4 milestone Mar 25, 2020
jeherve
jeherve requested changes Mar 26, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well for me. I only have one question, below.

extensions/blocks/wordads/edit.js Outdated Show resolved Hide resolved
@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 26, 2020
@matticbot
Copy link
Contributor

rclations, Your synced wpcom patch D40854-code has been updated.

@rclations rclations added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Mar 26, 2020
jeherve
jeherve approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be good now. Merging.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 26, 2020
@jeherve jeherve merged commit 3eb935f into master Mar 26, 2020
@jeherve jeherve deleted the update/wordads-block-mobile-toggle branch March 26, 2020 15:24
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Mar 26, 2020
@jeherve
Copy link
Member

jeherve commented Mar 26, 2020

r204890-wpcom

jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
Changelog: add #15120
4ec34b2
jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
8.4 Changelog (#15075)
0eb0b35 
* Initial changelog entry

* Changelog: add #14904

* Changelog: add #14910

* Changelog: add #14913

* Changelog: add #14916

* Changelog: add #14922

* Changelog: add #14924

* Changelog: add #14925

* Changelog: add #14928

* Changelog: add #14840

* Changelog: add #14841

* Changelog: add #14842

* Changelog: add #14826

* Changelog: add #14835

* Changelog: add #14859

* Changelog: add #14884

* Changelog: add #14888

* Changelog: add #14817

* Changelog: add #14814

* Changelog: add #14819

* Changelog;: add #14797

* Changelog: add #14798

* Changelog: add #14802

* Changelog: add #13676

* Changelog: add #13744

* Changelog: add #13777

* Changelog: add #14446

* Changelog: add #14739

* Changelog: add #14770

* Changelog: add #14784

* Changelog: add #14897

* Changelog: add #14898

* Changelog: add #14968

* Changelog: add #14985

* Changelog: add #15044

* Changelog: add #15052

* Update to remove Podcast since it remains in Beta

* Changelog: add #14803

* Changelog: add #15028

* Changelog: add #15065

* Changelog:add #14886

* Changelog: add #15118

* Changelog: add #14990

* Changelog: add #14528

* Changelog: add #15120

* Changelog: add #15126

* Changelog: add #15049

* Chanegelog: add #14852

* Changelog: add #15090

* Changelog: add #15138

* Changelog: add #15124

* Changelog:add #15055

* Changelog: add #15017

* Changelog: add #15109

* Changelog: add #15145

* Changelog:add #15096

* Changelog:add #15153

* Changelog: add #15133

* Changelog: add #14960

* Changelog: add #15127

* Changelog: add #15056

* Copy current changelog to changelog archive.

* Clarify changelog description
@jeherve jeherve mentioned this pull request May 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@dbspringer dbspringer dbspringer left review comments

@cphilleo cphilleo Awaiting requested review from cphilleo

@phpmypython phpmypython Awaiting requested review from phpmypython

Assignees

@rclations rclations

Labels
[Block] Ad [Feature] WordAds Touches WP.com Files
Projects
None yet
Milestone
8.4
Development

Successfully merging this pull request may close these issues.
5 participants
@rclations @matticbot @jetpackbot @dbspringer @jeherve