Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WordAds Block: Remove toggle from canvas #15700

Closed
apeatling opened this issue May 6, 2020 · 2 comments
Closed

WordAds Block: Remove toggle from canvas #15700

apeatling opened this issue May 6, 2020 · 2 comments
Assignees
@apeatling
Labels
Blocks V2 [Feature] WordAds [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@apeatling
Copy link
Member

apeatling commented May 6, 2020 •
edited
Loading

The Ads block looks to be used quite a bit among users. It also has the same problem of using toggles in the canvas of the block — it should be moved to the sidebar.

image-9
@apeatling apeatling added Blocks V2 [Feature] WordAds [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels May 6, 2020
@apeatling apeatling self-assigned this May 6, 2020
@jeherve
Copy link
Member

jeherve commented May 7, 2020

I believe this was done in #15120. Is this what you had in mind?

@jeherve jeherve added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label May 7, 2020
@apeatling
Copy link
Member Author

Yes! Perfect. Closing this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apeatling apeatling

Labels
Blocks V2 [Feature] WordAds [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeherve @apeatling