Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eventbrite block: add link to saved HTML #14510

Merged
merged 4 commits into from
Jan 30, 2020
Merged

Eventbrite block: add link to saved HTML #14510

merged 4 commits into from
Jan 30, 2020

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Jan 29, 2020 •
edited
Loading

Changes proposed in this Pull Request:

  • This will allow displaying useful info in RSS feeds / subscriptions emails, or when one disables the Jetpack plugin.

Related: #14435

Testing instructions:

  • In a new post, insert an Eventbrite block.
  • Publish it; it should be displayed nicely on the frontend, with no extra link displayed. In the HTML, however, you should notice something like this:
<!-- wp:jetpack/eventbrite {"url":"https://www.eventbrite.com/e/tune-into-innovation-design-terminal-demo-day-2020-tickets-88665223069","eventId":88665223069,"useModal":false,"text":"Testing something","backgroundColor":"primary"} -->
<div id="eventbrite-widget-88665223069" class="wp-block-jetpack-eventbrite"><a class="eventbrite__direct-link" href="https://www.eventbrite.com/e/tune-into-innovation-design-terminal-demo-day-2020-tickets-88665223069">https://www.eventbrite.com/e/tune-into-innovation-design-terminal-demo-day-2020-tickets-88665223069</a></div>
<!-- /wp:jetpack/eventbrite -->
  • This should work well for both block styles.

Proposed changelog entry for your changes:

  • N/A

@jeherve
Eventbrite: add a link to the saved modal HTML
ac99423 
This will allow displaying useful info in RSS feeds / subscriptions emails, or when one disables the Jetpack plugin.
@jeherve
Add CSS to hide the direct link.
8fd987f
@jeherve
Enqueue CSS when not using modal view
ce21836
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] In Progress [Pri] Normal [Status] Needs Cherry-Pick [Block] Eventbrite labels Jan 29, 2020
@jeherve jeherve added this to the 8.2 milestone Jan 29, 2020
@jeherve jeherve requested a review from a team January 29, 2020 13:34
@jeherve jeherve self-assigned this Jan 29, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D38282-code before merging this PR. Thank you!

@jetpackbot
Copy link
Collaborator

jetpackbot commented Jan 29, 2020 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: February 11, 2020.
Scheduled code freeze: February 4, 2020

Generated by 🚫 dangerJS against 3a608d5

@matticbot
Copy link
Contributor

jeherve, Your synced wpcom patch D38282-code has been updated.

@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Jan 29, 2020
creativecoder
creativecoder reviewed Jan 29, 2020
View reviewed changes
Copy link
Contributor

@creativecoder creativecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for improving!

TIL about load_assets_as_required.

Note that depending on what direction we go for modal button behavior in #14512, we might not need the fallback markup for the modal embed type.

@kraftbj kraftbj self-requested a review January 30, 2020 17:04
kraftbj
kraftbj approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@kraftbj kraftbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised. It might be nice to be able to put a better link title than just the URL itself, but that's not a blocker for acceptance.

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 30, 2020
@jeherve jeherve merged commit 791a349 into master Jan 30, 2020
@jeherve jeherve deleted the add/link-saved-eventbrite branch January 30, 2020 17:23
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jan 30, 2020
jeherve added a commit that referenced this pull request Jan 30, 2020
@jeherve
[not verified] Eventbrite block: add link to saved HTML (#14510)
45c830a 
* Eventbrite: add a link to the saved modal HTML

This will allow displaying useful info in RSS feeds / subscriptions emails, or when one disables the Jetpack plugin.

* Add CSS to hide the direct link.

* Enqueue CSS when not using modal view

* Add link to button as well
@jeherve
Copy link
Member Author

jeherve commented Jan 30, 2020

Cherry-picked to branch-8.2 in 45c830a

@jeherve
Copy link
Member Author

jeherve commented Jan 31, 2020

r202370-wpcom

@creativecoder creativecoder mentioned this pull request Feb 5, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creativecoder creativecoder creativecoder left review comments

@kraftbj kraftbj kraftbj approved these changes

Assignees

@jeherve jeherve

Labels
[Block] Eventbrite [Pri] Normal Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
8.2
Development

Successfully merging this pull request may close these issues.
5 participants
@jeherve @matticbot @jetpackbot @kraftbj @creativecoder