Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add save functions for the OpenTable and Calendly blocks #14435

Merged
merged 2 commits into from
Jan 28, 2020

Conversation

scruffian
Copy link
Member

@scruffian scruffian commented Jan 22, 2020

Changes proposed in this Pull Request:

  • Adds save functions to both the OpenTable and Calendly blocks. This means that when these blocks are rendered outside of a post there will be fall back content (URLs)

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • p58i-8tn#comment-44442-p2

Testing instructions:

  • Add a Calendly block and enter a valid URL
  • Look in the code editor and check you see the URL between the comments, something like:

Screenshot 2020-01-22 at 17 11 23

  • Add an OpenTable block and enter a valid restaurant(s)
  • Look in the code editor and check you see the URL between the comments, something like:

Screenshot 2020-01-22 at 17 11 27

Proposed changelog entry for your changes:

  • no changelog

@scruffian scruffian added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Block] OpenTable [Block] Calendly labels Jan 22, 2020
@scruffian scruffian requested a review from a team January 22, 2020 17:09
@scruffian scruffian self-assigned this Jan 22, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello scruffian! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D38011-code before merging this PR. Thank you!

@jetpackbot
Copy link
Collaborator

jetpackbot commented Jan 22, 2020

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: February 11, 2020.
Scheduled code freeze: February 4, 2020

Generated by 🚫 dangerJS against 0d849ee

@jeherve jeherve added this to the 8.2 milestone Jan 24, 2020
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could those be full links so one can click on them when they're displayed outside of WordPress (e.g. subscription emails or feeds) or when the Jetpack plugin gets deactivated?

@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 24, 2020
@matticbot
Copy link
Contributor

scruffian, Your synced wpcom patch D38011-code has been updated.

@matticbot
Copy link
Contributor

scruffian, Your synced wpcom patch D38011-code has been updated.

@scruffian scruffian added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 27, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 28, 2020
@jeherve jeherve merged commit f7cf520 into master Jan 28, 2020
@jeherve jeherve deleted the add/save-functions branch January 28, 2020 10:28
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jan 28, 2020
@scruffian
Copy link
Member Author

r202188-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Calendly [Block] OpenTable [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants