Instant search: add product result component #13774
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion (#13365) Refactor search results and improve their display. Add display of when we make spelling corrections.
Adds filtering results to the widget sidebar. Filters are not yet interactive.
…13393) bugs fixed: - Long titles and text will no longer overlap the date in the results. - Count of total results will never get overlapped by very long search strings - Adds icons for different content types to give more context to the user: products, video, images, audio, code, etc (eventually we could let users click to filter on these too) - Does not show path when we have tags/categories - was taking up too much space
* Use underscores instead of camel case * Add support for filtering by tags and categories
Extract the sort settings from the URL and then use that to determine how results should be sorted when doing the api request. Prerequisite for adding support for the sorting selection dropdown.
* Implement support for date filters * Add support for modified and GMT filter options * Remove duplicate post tag filter logic * Remove querying for 'modified' field
* Add internal dependencies docblock * Add support for custom taxonomy filtering * Refactor handling of query strings (coupled to API logic)
* Add sort widget * Display list of sort options * Pre-select current sort from query string * Update sort options * Reflect sort selection in query string * Sorting works! Renamed getSearchSort to getSortQuery for consistency * Tidying * Add translation context Co-Authored-By: Greg Ichneumon Brown <[email protected]> * Add jetpack context to all translations * Address review feedback
Fixes many of the problems in #13391 particularly: - inserting results into the theme works in all those themes - the search form for all those themes works as search as you type as does the default core WP search widget - Adds some CSS for our search box and cleans it up - Adjust opacity when results are loading to give the user some feedback - Starts the search query after only 200ms rather than 500ms. Feels a lot snappier - Did some slight code cleanup and renamed the "widget" to "app" so it isn't confused with the WP widgets.
* Initial working version of infinite scroll * Add scroll check for infinite scrolling experience * Fix discrepancies from rebase * Pass response along as a property * Enable aggregations for non-paged requests * Preserve aggregations for paged response * Fix pagination bug
Simple 5 min caching layer to all api requests.
* Reduce icons in results. * Clean up filter styling. * Min height on results area so the window shouldn't bounce. * Fix zerif-lite theme * Slightly reduce spacing between checkbox and label in filters
Insert search and filter results onto the front end of any theme. Filters are always displayed. Woohoo!
This change adds TrainTracks analytics to Jetpack Instant Search.
These changes are unrelated to Jetpack Instant Search.
jsnmoon
force-pushed
the
instant-search-master
branch
from
97d6015 to
b73e2fb
Compare
bluefuton
force-pushed
the
instant-search-product-result
branch
from
9110591 to
f1c1e30
Compare
bluefuton
force-pushed
the
instant-search-product-result
branch
from
f1c1e30 to
aab2370
Compare
jsnmoon
force-pushed
the
instant-search-master
branch
from
435d373 to
90605a8
Compare
|
History is rather broken after the latest merge, so closing in favour of #13826. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
In Instant Search, all search results currently use the 'minimal' component. This PR introduces a 'product' component to be used for e-commerce sites. It displays the first image from the post.
Is this a new feature or does it add/remove features to an existing part of Jetpack?
Testing instructions:
To be added later.
Proposed changelog entry for your changes:
No changelog entry required.