Instant Search: add sort widget #13614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluefuton
added
[Type] Feature Request
[Feature] Search
bluefuton
force-pushed
the
add/instant-search-sorting-ui
branch
from
4e5652b to
5541f7c
Compare
|
Todo:
This PR does not use the user-specified default sort - we'll add in a followup PR. |
bluefuton
added
[Status] Needs Review
gibrown
reviewed
Oct 3, 2019
modules/search/instant-search/components/search-sort-widget.jsx
Outdated
Show resolved
Hide resolved
Co-Authored-By: Greg Ichneumon Brown <[email protected]>
jsnmoon
approved these changes
Oct 3, 2019
modules/search/instant-search/components/search-sort-widget.jsx
Outdated
Show resolved
Hide resolved
modules/search/instant-search/components/search-sort-widget.jsx
Outdated
Show resolved
Hide resolved
matticbot
removed
the
[Status] Needs Review
jsnmoon
added a commit
that referenced
this pull request
Oct 23, 2019
* Implement minimal search results and spelling correction (#13365) * Add filtering display (#13371) * Fix search result display bugs and make improvements (#13393) * Add rudimentary support for filtering on post types (#13430) * Add support for filtering on categories and tags (#13505) * Add instant search sorting based on the URL (#13377) * Add support for filtering on dates (#13545) * Add custom taxonomy filtering (#13605) * add sort widget (#13614) * fix many theme incompatibilities (#13602) * Add infinite scrolling (#13684) * Add caching to the api requests (#13714) * Clean up some design bugs/issues (#13721) * Fix labels for post types when we have them. (#13750) * Add localization and formatting of all dates (#13748) * search from any page on the site (#13713) * Hook up default options (inc. sort) (#13742) * Add TrainTracks analytics (#13730) * Create PostTypeIcon component (#13790) * Upgrade to Preact 10 (#13794) * Add comments component (#13797) * Address review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This enables sorting of search results from Jetpack Instant Search.
Is this a new feature or does it add/remove features to an existing part of Jetpack?
Yes, this adds a sorting UI to Jetpack Instant Search.
Testing instructions:
Add define( "JETPACK_SEARCH_PROTOTYPE", true ); to your wp-config.php.
Ensure that your site has the Jetpack Pro plan and has Jetpack Search enabled.
Add a Jetpack Search widget to the Search page sidebar.
Enter a query into a search widget. Alternatively, navigate to a search page like /?s=privacy.
Ensure that you can use the sort dropdown to change sort order.
Proposed changelog entry for your changes:
Not required.