Release script: update list of files that ship with each release #12832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.svnignore uses the ** pattern to match any subdirectory, but that pattern is only supported from Bash 4, with globstar. Let's require release leads to use a recent version of Bash, or install it if they don't have it yet.
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: July 2, 2019. |
jeherve
added
[Status] Needs Review
zinigor
previously approved these changes
Jun 24, 2019
zinigor
added
[Status] Ready to Merge
Co-Authored-By: Igor Zinovyev <[email protected]>
zinigor
approved these changes
Jun 24, 2019
matticbot
removed
the
[Status] Ready to Merge
jeherve
added a commit
that referenced
this pull request
Jun 24, 2019
* Add more files to svnignore as we don't need them on prod * Require Bash 4 to run the deploy to SVN script .svnignore uses the ** pattern to match any subdirectory, but that pattern is only supported from Bash 4, with globstar. Let's require release leads to use a recent version of Bash, or install it if they don't have it yet. * Do not ship package tests and readme files * Add more package files to list of files excluded from the release Co-Authored-By: Igor Zinovyev <[email protected]>
|
Cherry-picked to |
jeherve
added a commit
that referenced
this pull request
Jun 25, 2019
* Add more files to svnignore as we don't need them on prod * Require Bash 4 to run the deploy to SVN script .svnignore uses the ** pattern to match any subdirectory, but that pattern is only supported from Bash 4, with globstar. Let's require release leads to use a recent version of Bash, or install it if they don't have it yet. * Do not ship package tests and readme files * Add more package files to list of files excluded from the release Co-Authored-By: Igor Zinovyev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12808
Changes proposed in this Pull Request:
.svnignorevendor/automattic.css/*.css.mapfiles.Once we take care of that first item, the following existing rules from the
.svnignorefile will be respected:As a result, we will not be shipping any more unbuilt block files with the plugin. We should make sure this is okay, and won't cause any issues with block translations: p1561379577167900-slack-jetpack-crew
The easiest way to handle that first item seems to be to rely on recent versions of Bash (not shipped by default with Mac OS), that support globstar. Since there are only a handful of us pushing releases out, I think it's not too bad of a thing to require. I opted to suggest an installation via Homebrew when one does not run an up to date version of Bash since Mac OS is the majority around these parts. @zinigor I realize this excludes you. :( What do you think about this?
Testing instructions:
yarn build-productioncurl -O https://gist.githubusercontent.com/jeherve/2692e31475aa339233f98387b743208c/raw/eddd55b9a6ea3626cc1442e4d4ee9b37354f7448/12832.diff && git apply 12832.diff./tools/12832.shcd /tmp/12832vendor/automattic/directory, except for test files.Proposed changelog entry for your changes: