Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.tools-to-svn.sh : globstar: invalid shell option name #14868

Closed
mdbitz opened this issue Mar 3, 2020 · 3 comments
Closed

.tools-to-svn.sh : globstar: invalid shell option name #14868

mdbitz opened this issue Mar 3, 2020 · 3 comments
Assignees
Labels
Build [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Type] Task

Comments

@mdbitz
Copy link
Contributor

mdbitz commented Mar 3, 2020

During release of the 8.3 branch I experienced an error where ignore files weren't ignored by the script.

Purging paths included in .svnignore
./tools/deploy-to-svn.sh: line 84: shopt: globstar: invalid shell option name

We need to review why this occurred, and if there are any dependencies that need to be added/checked for and if there is error/warning messages that need to be generated to ensure extra files don't make their way to the svn repo.

Steps to reproduce the issue

  1. ./tools/deploy-to-svn.sh 8.3

What I expected

js, images, css in extensions folder to be ignored

What happened instead

js, css, images were in the trunk and had to be manually removed.

@mdbitz mdbitz self-assigned this Mar 3, 2020
@jeherve
Copy link
Member

jeherve commented Mar 4, 2020

This was introduced in #12832.

The script was meant to catch whether you used a recent version of Bash that supports globstar.

What version do you run on your machine?

@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! Build labels Mar 4, 2020
@mdbitz
Copy link
Contributor Author

mdbitz commented Mar 4, 2020

:nod: I did receive the message and responded "y". I'll have to run the script some more and check versions, will come back with more info.

@mdbitz
Copy link
Contributor Author

mdbitz commented Jun 10, 2020

have since updated to new laptop and latest version of bash doesn't have this issue. closing.

@mdbitz mdbitz closed this as completed Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Type] Task
Projects
None yet
Development

No branches or pull requests

2 participants