-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post Flair: Fix official LinkedIn and Pinterest buttons vertical alignement by displaying elements as a block #12037
Conversation
…aying the parent `span` as a block
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: April 29, 2019. |
We need to do the same alignment for the Pinterest icon: Found on automattic.design: https://automattic.design/2019/03/25/how-to-improve-as-a-speaker-by-deconstructing-talks/ |
…laying the parent `span` as a block
Caution: This PR has changes that must be merged to WordPress.com |
Done in 20cbc5e |
span
as a blockThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to work well on my end 👍
Another user report of the Pinterest button being misaligned. 12101491-hc I have tested this, and the issue seems to be fixed on simple sites, but not AT sites:
Screenshot is from Twenty Nineteen theme, but every WordPress.com theme tried produced the same result. |
@kylemcph The fix hasn't been shipped in Jetpack just yet, so you won't see it fixed on AT sites until the next Jetpack release, scheduled for May 7th. |
Fixes #8883
Fixes #11407
Changes proposed in this Pull Request:
Before:
After:
Testing instructions:
Proposed changelog entry for your changes: