Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Flair: Fix official LinkedIn and Pinterest buttons vertical alignement by displaying elements as a block #12037

Merged
merged 2 commits into from
Apr 16, 2019

Conversation

thomasguillot
Copy link
Contributor

@thomasguillot thomasguillot commented Apr 12, 2019

Fixes #8883
Fixes #11407

Changes proposed in this Pull Request:

  • Force the LinkedIn's parent span & Pinterest link to be displayed as a block rather than an inline-block

Before:

Screenshot 2019-04-12 at 14 28 27

After:

Screenshot 2019-04-12 at 14 28 41

Testing instructions:

  • Add sharing buttons to a post or page including LinkedIn and Pinterest
  • Make sure you are using the "official" buttons
  • Are they aligned?

Proposed changelog entry for your changes:

  • Fix official LinkedIn and Pinterest buttons vertical alignement

@thomasguillot thomasguillot requested a review from a team April 12, 2019 13:31
@jetpackbot
Copy link
Collaborator

jetpackbot commented Apr 12, 2019

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 29, 2019.
Scheduled code freeze: April 22, 2019

Generated by 🚫 dangerJS against 20cbc5e

@thomasguillot thomasguillot added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Apr 12, 2019
@sixhours
Copy link
Contributor

We need to do the same alignment for the Pinterest icon:

Screen Shot 2019-04-12 at 11 42 13 AM

Found on automattic.design: https://automattic.design/2019/03/25/how-to-improve-as-a-speaker-by-deconstructing-talks/

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello thomasguillot! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D26877-code before merging this PR. Thank you!

@thomasguillot
Copy link
Contributor Author

We need to do the same alignment for the Pinterest icon

Done in 20cbc5e

@thomasguillot thomasguillot changed the title Post Flair: Fix official LinkedIn button vertical alignement by displaying the parent span as a block Post Flair: Fix official LinkedIn and Pinterest buttons vertical alignement by displaying elements as a block Apr 12, 2019
@jeherve jeherve added [Feature] Sharing Post sharing, sharing buttons [Type] Bug When a feature is broken and / or not performing as intended labels Apr 15, 2019
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work well on my end 👍

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Apr 15, 2019
@jeherve jeherve added this to the 7.3 milestone Apr 15, 2019
@kylemcph
Copy link

Another user report of the Pinterest button being misaligned.

12101491-hc

I have tested this, and the issue seems to be fixed on simple sites, but not AT sites:


Direct link to image: https://cld.wthms.co/PJxSat

Screenshot is from Twenty Nineteen theme, but every WordPress.com theme tried produced the same result.

@jeherve
Copy link
Member

jeherve commented Apr 16, 2019

@kylemcph The fix hasn't been shipped in Jetpack just yet, so you won't see it fixed on AT sites until the next Jetpack release, scheduled for May 7th.

@jeherve jeherve merged commit c719ce0 into master Apr 16, 2019
@jeherve jeherve deleted the fix/linkedin-share-button branch April 16, 2019 15:05
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Apr 16, 2019
kraftbj added a commit that referenced this pull request Apr 26, 2019
kraftbj added a commit that referenced this pull request Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Sharing Post sharing, sharing buttons [Status] Tested on WP.com Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sharing: Official LinkedIn icon misaligned Sharing: Official Pinterest button misaligned
7 participants