Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing: Official Pinterest button misaligned #8883

Closed
alaczek opened this issue Feb 19, 2018 · 6 comments · Fixed by #12037
Closed

Sharing: Official Pinterest button misaligned #8883

alaczek opened this issue Feb 19, 2018 · 6 comments · Fixed by #12037
Labels
[Feature] Sharing Post sharing, sharing buttons [Pri] Low [Status] Needs Design Review Design has been added. Needs a review! [Type] Bug When a feature is broken and / or not performing as intended

Comments

@alaczek
Copy link
Contributor

alaczek commented Feb 19, 2018

When switching to "Official buttons" option in sharing module, the Pinterest button is displaying slightly lower then other sharing buttons. This does not seem to be theme specific (I was able to reproduce in Apostrophe 2, Toujours, Twenty Seventeen) and the issue is visible on the settings page in Calypso as well.

Steps to reproduce the issue

  1. Navigate to Sharing > Sharing Buttons in Calypso.
  2. Enable a few services, including Pinterest.
  3. Select "Official Buttons" under Button style.
  4. Save and view a post/page.

What I expected

I expected all the buttons to be aligned.

What happened instead

The Pinterest button is displayed slightly lower then others.

Screenshots

Calypso settings page:
image

Front end:
image

@alaczek alaczek added the [Feature] Sharing Post sharing, sharing buttons label Feb 19, 2018
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Design Review Design has been added. Needs a review! [Pri] Normal labels Feb 20, 2018
@arunsathiya
Copy link

arunsathiya commented Mar 22, 2018

2144105-hc

@stale
Copy link

stale bot commented Sep 18, 2018

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale
Copy link

stale bot commented Mar 17, 2019

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Mar 17, 2019
@Aurorum
Copy link
Contributor

Aurorum commented Mar 17, 2019

Still an issue, along with the LinkedIn one.

@Aurorum
Copy link
Contributor

Aurorum commented Apr 13, 2019

PR in #12037

@kylemcph
Copy link

Another user report of the Pinterest button being misaligned.

12101491-hc

I have tested this, and the issue seems to be fixed on simple sites, but not AT sites:


Direct link to image: https://cld.wthms.co/PJxSat

Screenshot is from Twenty Nineteen theme, but every WordPress.com theme tried produced the same result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Sharing Post sharing, sharing buttons [Pri] Low [Status] Needs Design Review Design has been added. Needs a review! [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
5 participants