Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tiled gallery block: switch "masonry" keyword to "pictures" #11787

Merged
merged 1 commit into from
Apr 3, 2019
Merged

Tiled gallery block: switch "masonry" keyword to "pictures" #11787

merged 1 commit into from
Apr 3, 2019

Conversation

simison
Copy link
Member

@simison simison commented Apr 1, 2019 •
edited
Loading

Resolves Automattic/wp-calypso#29780

Changes proposed in this Pull Request:

  • switch "masonry" keyword to "pictures"

Testing instructions:

  • Tiled gallery block should show up when typing "pictures" in block picker.

Proposed changelog entry for your changes:

@simison simison added [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Pri] Low labels Apr 1, 2019
@simison simison requested a review from a team April 1, 2019 08:20
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello simison! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D26243-code before merging this PR. Thank you!

@jetpackbot
Copy link
Collaborator

jetpackbot commented Apr 1, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 29, 2019.
Scheduled code freeze: April 22, 2019

Generated by 🚫 dangerJS against 4d42e6d

@simison simison added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Apr 1, 2019
@simison simison requested a review from a team April 1, 2019 08:55
jeherve
jeherve previously approved these changes Apr 1, 2019
View reviewed changes
@simison
Copy link
Member Author

simison commented Apr 1, 2019

Please don't merge before #11743 — just to avoid rebasing that big one.

@sirreal sirreal added the DO NOT MERGE don't merge it! label Apr 1, 2019
sirreal
sirreal previously approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Added do not merge label, we can remove when #11743 lands.

@sirreal sirreal removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Apr 1, 2019
@scruffian scruffian dismissed stale reviews from sirreal and jeherve via 4d42e6d April 3, 2019 10:51
@scruffian scruffian force-pushed the update/tiled-gallery-keywords branch from 5952e38 to 4d42e6d Compare April 3, 2019 10:51
@matticbot
Copy link
Contributor

simison, Your synced wpcom patch D26243-code has been updated.

@simison simison added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed DO NOT MERGE don't merge it! labels Apr 3, 2019
@sirreal sirreal added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Apr 3, 2019
jeherve
jeherve approved these changes Apr 3, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@scruffian scruffian merged commit e2f2369 into master Apr 3, 2019
@scruffian scruffian deleted the update/tiled-gallery-keywords branch April 3, 2019 10:59
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@sirreal sirreal sirreal left review comments

Assignees
No one assigned
Labels
[Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Pri] Low Touches WP.com Files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tiled gallery block: evaluate keywords
7 participants
@simison @matticbot @jetpackbot @jeherve @sirreal @kraftbj @scruffian