Extensions: drop i18n wrapper

[sirreal]

Closes: #11656

Changes proposed in this Pull Request:

• Drop the now-obsolete i18n helper in extensions/utils
• Change __, _n, _x, _nx() imports to import directly from @wordpress/i18n
• Add jetpack textdomain as last argument to all those functions

Testing instructions:

• Verify that blocks still work
• (Not sure if we currently expect translations to work? They might live in a different place than they will once this is merged and used for string extraction.)

Proposed changelog entry for your changes:

Blocks: Drop i18n wrapper, use @wordpress/i18n directly.

[simison]

Do we now need to add jetpack textdomain in translation functions?

[sirreal]

Do we now need to add jetpack textdomain in translation functions?

Yes, I believe so.

[ockham]

This could do the trick

function addTextdomain( j, root, name ) {
  	return root
		.find( j.CallExpression, { callee: { type: 'Identifier', name } } )
		.forEach( path => {
			j( path ).replaceWith( () => {
				path.node.arguments = path.node.arguments.concat( j.stringLiteral( 'jetpack' ) );
              	return path.node;
			} );
		} )
		.toSource( { quote: 'single' } );
}

export default function transformer( file, api ) {
	const j = api.jscodeshift;
	var ret = file.source;
	ret = addTextdomain( j, j( ret ), '__' ); 
 	ret = addTextdomain( j, j( ret ), '_n' );
   	ret = addTextdomain( j, j( ret ), '_x' );
   	ret = addTextdomain( j, j( ret ), '_nx' );

	return ret;
}

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 2, 2019.
Scheduled code freeze: March 26, 2019

Generated by 🚫 dangerJS against 40e357e

[simison]

Rebased after vr block folder had been removed.

[simison]

Builds well and blocks work.

Since there have been issues with i18n and blocks in master, we might need to verify separately that translations work before 7.3 ships.

I'm seeing some translations for business hours block tho (maanantai = monday):

[ockham]

I'll try and produce a WP.com phab diff.

[ockham]

I'll try and produce a WP.com phab diff.

D26251-code

[scruffian]

I tested this and it worked as expected. I tried switching branches and everything continued to work. Code looks good too.

[jeherve]

It works well for me 👍

[ockham]

Thanks everyone for reviewing!