Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facebook Page Plugin widget stream missing #13717

Closed
julsyd opened this issue Oct 10, 2019 · 1 comment · Fixed by #13725
Closed

Facebook Page Plugin widget stream missing #13717

julsyd opened this issue Oct 10, 2019 · 1 comment · Fixed by #13725
Assignees
@jeherve
Labels
[Feature] Extra Sidebar Widgets [Type] Bug When a feature is broken and / or not performing as intended
Milestone
7.9

Comments

@julsyd
Copy link

julsyd commented Oct 10, 2019

Steps to reproduce the issue

  1. Go to 'WP Admin > Appearance > Widgets'
  2. Add a Facebook Page Plugin widget to any widget area.
  3. Enable Show Stream in the widget settings.
  4. Save the widget and view it on the live site.

What I expected

I expected the widget to display a stream of recent posts.

What happened instead

The widget only shows the cover photo (if enabled), and does not show a stream of recent posts. It was showing the stream until earlier today (first it disappeared only in Safari, and then Chrome and Firefox about 15 minutes later).

Screenshots

Screen Shot on 2019-10-10 at 17:54:58
Screen Shot on 2019-10-10 at 17:54:43
@julsyd julsyd added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Extra Sidebar Widgets labels Oct 10, 2019
@jeherve jeherve self-assigned this Oct 11, 2019
@jeherve jeherve added this to the 7.9 milestone Oct 11, 2019
@jeherve
Copy link
Member

jeherve commented Oct 11, 2019

Good catch! It would seem that Facebook has now deprecated this attribute:

The attribute data-show-posts is deprecated. Please use the attribute tabs/data-tabs and use the value timeline to show posts from the Page's timeline.

PR incoming.

jeherve added a commit that referenced this issue Oct 11, 2019
@jeherve
Facebook Page Plugin: update deprecated stream attribute
b2519a8 
Fixes #13717

This attribute has now been deprecated by Facebook:
> The attribute data-show-posts is deprecated. Please use the attribute tabs/data-tabs and use the value timeline to show posts from the Page's timeline.
-- https://developers.facebook.com/docs/plugins/page-plugin/

This updates to the new recommended attribute.
@jeherve jeherve mentioned this issue Oct 11, 2019
Merged
kraftbj pushed a commit that referenced this issue Oct 25, 2019
@jeherve @kraftbj
Facebook Page Plugin: update deprecated stream attribute (#13725)
8f87bd7 
* Facebook Page Plugin: update deprecated stream attribute

Fixes #13717

This attribute has now been deprecated by Facebook:
> The attribute data-show-posts is deprecated. Please use the attribute tabs/data-tabs and use the value timeline to show posts from the Page's timeline.
-- https://developers.facebook.com/docs/plugins/page-plugin/

This updates to the new recommended attribute.

* Update Widget UI as per recommendations.

See #13725 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeherve jeherve

Labels
[Feature] Extra Sidebar Widgets [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
7.9
Development

Successfully merging a pull request may close this issue.

Facebook Page Plugin: update deprecated stream attribute Automattic/jetpack
2 participants
@jeherve @julsyd